Page MenuHomePhabricator

Please rewrite sync-with-gerrit.py to use Gerrit REST API
Open, LowPublic

Description

As told at T194156#4194894 and by Chad on IRC, the sync-with-gerrit.py script should be rewritten to use REST API instead of requiring access to the gerrit server which only few people have. Thanks.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 9 2018, 10:24 PM

This script exists in mediawiki/extensions and mediawiki/skins

demon added a subscriber: demon.Jun 9 2018, 2:25 AM

Every user has SSH access to the server. And you'd need to be a user to do the commit to the repo....who's being excluded here?

But I don't disagree, the REST api is always an improvement over SSH. That alone is reason enough to do this. Use the pygerrit2 library :)

demon moved this task from Bugs & stuff to Local hacks on the Gerrit board.Jun 9 2018, 2:28 AM
Krenair added a subscriber: Krenair.Jun 9 2018, 2:32 AM
$ ssh -a -p 29418 maurelio@gerrit.wikimedia.org

  ****    Welcome to Gerrit Code Review    ****

  Hi MarcoAurelio, you have successfully connected over SSH.

  Unfortunately, interactive shells are disabled.
  To clone a hosted Git repository, use:

  git clone ssh://maurelio@gerrit.wikimedia.org:29418/REPOSITORY_NAME.git

Connection to gerrit.wikimedia.org closed.

@demon ^^
So no, I cannot use that script unless I am doing something wrong here.

demon added a comment.EditedJun 9 2018, 10:48 AM

You can't have an interactive shell. But sync-with-gerrit doesn't do that....try appending gerrit ls-projects to that

Generally, see this.... https://gerrit.wikimedia.org/r/Documentation/cmd-index.html#user_commands

Vvjjkkii renamed this task from Please rewrite sync-with-gerrit.py to use Gerrit REST API to l9caaaaaaa.Jul 1 2018, 1:10 AM
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed subscribers: MarcoAurelio, Aklapper.
CommunityTechBot renamed this task from l9caaaaaaa to Please rewrite sync-with-gerrit.py to use Gerrit REST API.Jul 1 2018, 2:39 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
hashar triaged this task as Low priority.Apr 19 2019, 8:25 AM