Page MenuHomePhabricator
Create Task
Maniphest T194319

Make the error message for "The configuration setting '$key' was already set by another extension" better
Closed, ResolvedPublic
Actions

Description

The error message from ExtensionRegistration should be improved to say which extensions that have the key set already.

This would help greatly in fixing extensions.

This should be considered a blocker for 1.31.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+15 -11registration: Improve duplicate config setting exception
mediawiki/coreREL1_31+15 -11registration: Improve duplicate config setting exception
mediawiki/extensions/MsCalendarmaster+8 -9Move wgAjaxExportList out side of config: {}
mediawiki/extensions/AJAXPollmaster+4 -5Move wgAjaxExportList out side of config: {}
mediawiki/extensions/MsCalendarREL1_31+8 -9Move wgAjaxExportList out side of config: {}
mediawiki/extensions/AJAXPollREL1_31+4 -5Move wgAjaxExportList out side of config: {}
Customize query in gerrit

Event Timeline

Paladox created this task.May 9 2018, 10:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 9 2018, 10:25 PM
Legoktm added a comment.May 9 2018, 10:31 PM

This would help greatly in fixing extensions.

Can't you just grep or search for the config setting?

Patches are definitely welcome, but I'm not sure I'd consider this a blocker.

Paladox added a comment.May 9 2018, 10:36 PM
In T194319#4195632, @Legoktm wrote:

This would help greatly in fixing extensions.

Can't you just grep or search for the config setting?

Patches are definitely welcome, but I'm not sure I'd consider this a blocker.

The error message is the most un help full, it tells you the config but not where it's happening.

Paladox added a comment.May 9 2018, 10:43 PM

Found the extensions https://phabricator.miraheze.org/P59

Paladox added a comment.May 9 2018, 10:51 PM

@Legoktm would using a callback work around the problem for:

/srv/mediawiki/w/extensions/MsCalendar/extension.json:66: "AjaxExportList": [
/srv/mediawiki/w/extensions/AJAXPoll/extension.json:67: "AjaxExportList": [
/srv/mediawiki/w/extensions/MsUpload/extension.json:57: "AjaxExportList": [

?

gerritbot added a subscriber: gerritbot.May 9 2018, 11:01 PM

Change 432316 had a related patch set (by Paladox) published:
[mediawiki/extensions/AJAXPoll@master] Move wgAjaxExportList out side of config: {}

https://gerrit.wikimedia.org/r/432316

gerritbot added a project: Patch-For-Review.May 9 2018, 11:01 PM
gerritbot added a comment.May 9 2018, 11:04 PM

Change 432317 had a related patch set (by Paladox) published:
[mediawiki/extensions/MsCalendar@master] Move wgAjaxExportList out side of config: {}

https://gerrit.wikimedia.org/r/432317

gerritbot added a comment.May 9 2018, 11:16 PM

Change 432323 had a related patch set uploaded (by MacFan4000; owner: Paladox):
[mediawiki/extensions/AJAXPoll@REL1_31] Move wgAjaxExportList out side of config: {}

https://gerrit.wikimedia.org/r/432323

gerritbot added a comment.May 9 2018, 11:17 PM

Change 432324 had a related patch set uploaded (by MacFan4000; owner: Paladox):
[mediawiki/extensions/MsCalendar@REL1_31] Move wgAjaxExportList out side of config: {}

https://gerrit.wikimedia.org/r/432324

gerritbot added a comment.May 9 2018, 11:22 PM

Change 432316 merged by jenkins-bot:
[mediawiki/extensions/AJAXPoll@master] Move wgAjaxExportList out side of config: {}

https://gerrit.wikimedia.org/r/432316

gerritbot added a comment.May 9 2018, 11:27 PM

Change 432317 merged by jenkins-bot:
[mediawiki/extensions/MsCalendar@master] Move wgAjaxExportList out side of config: {}

https://gerrit.wikimedia.org/r/432317

gerritbot added a comment.May 9 2018, 11:45 PM

Change 432323 merged by jenkins-bot:
[mediawiki/extensions/AJAXPoll@REL1_31] Move wgAjaxExportList out side of config: {}

https://gerrit.wikimedia.org/r/432323

gerritbot added a comment.May 9 2018, 11:45 PM

Change 432324 merged by jenkins-bot:
[mediawiki/extensions/MsCalendar@REL1_31] Move wgAjaxExportList out side of config: {}

https://gerrit.wikimedia.org/r/432324

demon moved this task from Backlog to Core on the MW-1.31-release board.May 15 2018, 1:13 PM
Legoktm claimed this task.May 15 2018, 5:23 PM
gerritbot added a comment.May 15 2018, 5:32 PM

Change 433193 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] registration: Improve duplicate config setting exception

https://gerrit.wikimedia.org/r/433193

gerritbot added a comment.May 15 2018, 11:20 PM

Change 433193 merged by jenkins-bot:
[mediawiki/core@master] registration: Improve duplicate config setting exception

https://gerrit.wikimedia.org/r/433193

gerritbot added a comment.May 15 2018, 11:41 PM

Change 433300 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@REL1_31] registration: Improve duplicate config setting exception

https://gerrit.wikimedia.org/r/433300

gerritbot added a comment.May 15 2018, 11:54 PM

Change 433300 merged by jenkins-bot:
[mediawiki/core@REL1_31] registration: Improve duplicate config setting exception

https://gerrit.wikimedia.org/r/433300

Legoktm closed this task as Resolved.May 15 2018, 11:54 PM
ReleaseTaggerBot added projects: MW-1.31-release-notes, MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)).May 16 2018, 12:00 AM
• Vvjjkkii renamed this task from Make the error message for "The configuration setting '$key' was already set by another extension" better to k9caaaaaaa.Jul 1 2018, 1:10 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Legoktm as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from k9caaaaaaa to Make the error message for "The configuration setting '$key' was already set by another extension" better.Jul 1 2018, 2:39 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Legoktm.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL