⚓ T194412 Make undo fail gracefully for non-main slots.

	Subject	Repo	Branch	Lines +/-
	WikiPage: Return false from hasDifferencesOutsideMainSlot if no differences at all	mediawiki/core	master	+1 -1
	Make undo fail if more than just the main slot is affected.	mediawiki/core	master	+116 -8

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	BUG REPORT	None	T12863 Links on commons upload summaries do not link to commons
Open		None	T5498 Image history is confusing
Stalled		None	T96384 Integrate file revisions with description page history
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Open		None	T122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
Open		None	T135221 Make TimedText content an integral part of the File page
Open	Feature	None	T2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
Open		None	T132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Open	Feature	None	T14963 allow per-page exceptions to spam blacklist
Open		None	T203157 Make the spam whitelist its own slot
Open	Feature	None	T56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
Stalled		None	T174043 Deploy Multi-Content Revisions
Open		None	T174022 Implement multi-content revisions
Open		None	T189808 Make undo work with multiple slots.
Resolved		daniel	T194412 Make undo fail gracefully for non-main slots.
Resolved		Anomie	T205101 McrUndoAction preview doesn't work

CCicalese_WMF triaged this task as Medium priority.May 10 2018, 4:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 10 2018, 4:24 PM

CCicalese_WMF moved this task from Inbox to MCR-SDC Storage Layer - phase 1 on the Multi-Content-Revisions board.May 10 2018, 4:26 PM

CCicalese_WMF edited projects, added Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1); removed Multi-Content-Revisions.

Note that undo can span multiple revisions; if we go with this we need to disable that somehow. Also single-edit undos where the edit was created in some nonstandard way (e.g. hard revision deletion).

Why would you need to do that, as long as the whole set of edits only changes one slot?

So just let the user load the undo screen and show an error message if more than one slot changed? I guess that makes more sense.

CCicalese_WMF moved this task from Inbox to Watching on the MediaWiki-Platform-Team-Archived board.May 15 2018, 12:55 AM

daniel renamed this task from Make action=undo work properly with multiple slots (phase 1) to Make action=undo work with non-main slots..May 15 2018, 9:54 AM

daniel updated the task description. (Show Details)

daniel updated the task description. (Show Details)May 15 2018, 9:57 AM

daniel mentioned this in T189808: Make undo work with multiple slots..May 15 2018, 10:03 AM

daniel added a parent task: T194750: Deploy Structured Data on Commons baseline .May 15 2018, 11:26 AM

CCicalese_WMF removed a parent task: T194750: Deploy Structured Data on Commons baseline .May 31 2018, 2:58 AM

daniel claimed this task.Jun 19 2018, 5:15 PM

daniel moved this task from Backlog to In Progress on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.

Change 441070 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Make undo fail if more than just the main slot is affected.

https://gerrit.wikimedia.org/r/441070

gerritbot added a project: Patch-For-Review.Jun 19 2018, 5:21 PM

daniel moved this task from In Progress to Blocked on Review on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.Jun 19 2018, 5:21 PM

daniel moved this task from Blocked on Review to In Progress on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.

daniel moved this task from In Progress to Blocked on Review on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.Jun 21 2018, 4:49 PM

Change 441070 merged by jenkins-bot:
[mediawiki/core@master] Make undo fail if more than just the main slot is affected.

https://gerrit.wikimedia.org/r/441070

daniel renamed this task from Make action=undo work with non-main slots. to Make action=undo fail gracefully for non-main slots..Jun 23 2018, 9:08 AM

daniel closed this task as Resolved.

daniel updated the task description. (Show Details)

CCicalese_WMF moved this task from Blocked on Review to Done on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.Jun 26 2018, 4:25 AM

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 3:01 PM

• Vvjjkkii renamed this task from Make action=undo fail gracefully for non-main slots. to z6caaaaaaa.Jul 1 2018, 1:10 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed daniel as the assignee of this task.

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

CommunityTechBot renamed this task from z6caaaaaaa to Make action=undo fail gracefully for non-main slots..Jul 2 2018, 5:54 AM

CommunityTechBot closed this task as Resolved.

CommunityTechBot assigned this task to daniel.

CommunityTechBot lowered the priority of this task from High to Medium.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added subscribers: gerritbot, Aklapper.

CCicalese_WMF removed a project: Patch-For-Review.Jul 10 2018, 3:28 AM

CCicalese_WMF removed a project: MediaWiki-Platform-Team-Archived.Jul 12 2018, 12:44 AM

daniel renamed this task from Make action=undo fail gracefully for non-main slots. to Make undo fail gracefully for non-main slots..Jul 13 2018, 6:48 PM

Change 446606 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] WikiPage: Return false from hasDifferencesOutsideMainSlot if no differences at all

https://gerrit.wikimedia.org/r/446606

gerritbot added a project: Patch-For-Review.Jul 18 2018, 3:16 PM

Change 446606 merged by jenkins-bot:
[mediawiki/core@master] WikiPage: Return false from hasDifferencesOutsideMainSlot if no differences at all

https://gerrit.wikimedia.org/r/446606

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).Jul 18 2018, 8:00 PM

daniel added a subtask: T205101: McrUndoAction preview doesn't work.Sep 25 2018, 7:43 AM

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 16 2020, 6:42 PM