Page MenuHomePhabricator
Create Task
Maniphest T194424

Provide separate edit tags for Android and iOS apps
Closed, ResolvedPublic
Actions

Description

We can easily determine the total number of edits made via either the iOS or the Android app by using the public mobile app edit tag (example: English Wikipedia), which already indicates that the vast majority of edits from the Android app still comes from non-description edits (cf. T184096#4164186 ). However, this does not give us the numbers for Android (or iOS) separately.

To that end, we should have separate edit tags for the Android and iOS apps going forward. First step would probably be to look at the code that currently creates the mobile app edit and see if it can be modified to include ios app edit/android app edit in addition to mobile add edit. (See mw:Manual:Tags.)

It appears natural to calculate this number by project (wiki) first, followed by segments once the segmentation endeavor has something.

Details

SubjectRepoBranchLines +/-
Add platform-specific tags to edits submitted from apps.mediawiki/extensions/MobileAppmaster+10 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Tbayer created this task.May 10 2018, 7:55 PM
• Tbayer mentioned this in T184096: Editor analytics report for Android app (language).May 10 2018, 8:01 PM
nshahquinn-wmf triaged this task as Medium priority.May 10 2018, 8:07 PM
nshahquinn-wmf moved this task from Triage to Backlog on the Product-Analytics board.
• Tbayer added a project: Android-app-Bugs.Jun 5 2018, 2:02 PM
• Tbayer updated the task description. (Show Details)
Restricted Application added a project: Wikipedia-Android-App-Backlog. · View Herald TranscriptJun 5 2018, 2:02 PM
mpopov awarded a token.Jun 12 2018, 8:58 PM
• Tbayer renamed this task from Determine rate of edits made via the Android Wikipedia app to Provide separate edit tags for Android and iOS apps (was: Determine rate of edits made via the Android Wikipedia app).Jun 13 2018, 5:37 PM
• Tbayer added a project: iOS-app-Bugs.
• Tbayer updated the task description. (Show Details)
Restricted Application added a project: Wikipedia-iOS-App-Backlog. · View Herald TranscriptJun 13 2018, 5:37 PM
mpopov renamed this task from Provide separate edit tags for Android and iOS apps (was: Determine rate of edits made via the Android Wikipedia app) to Provide separate edit tags for Android and iOS apps.Jun 13 2018, 6:40 PM
mpopov updated the task description. (Show Details)
mpopov removed projects: iOS-app-Bugs, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Android-app-Bugs.
mpopov edited subscribers, added: • chelsyx; removed: • Tbayer, • Charlotte.
Dbrant subscribed.Jun 18 2018, 8:29 PM

The mobile-app-edit tag is added by the MobileApp extension (which is one of the only raisons d'être of this extension). This is because the editing API doesn't provide a way to set tags for each edit.

The extension simply looks at the User-agent and determines whether it matches WikipediaApp, meaning that we can very easily modify it to check more specifically for Android or iOS and set the corresponding tag.

gerritbot subscribed.Jun 18 2018, 8:29 PM

Change 440969 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[mediawiki/extensions/MobileApp@master] Add platform-specific tags to edits submitted from apps.

https://gerrit.wikimedia.org/r/440969

gerritbot added a project: Patch-For-Review.Jun 18 2018, 8:29 PM
gerritbot added a comment.Jun 18 2018, 9:04 PM

Change 440969 merged by jenkins-bot:
[mediawiki/extensions/MobileApp@master] Add platform-specific tags to edits submitted from apps.

https://gerrit.wikimedia.org/r/440969

• chelsyx mentioned this in T197174: Tag edits made in iOS app with an iOS-specific tag.Jun 18 2018, 9:25 PM
• chelsyx awarded a token.Jun 18 2018, 9:29 PM
Jdforrester-WMF assigned this task to • Mholloway.Jun 18 2018, 9:36 PM
Jdforrester-WMF edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Patch-For-Review.
Jdforrester-WMF moved this task from To Do to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
mpopov mentioned this in T197175: Tag edits made in Android app with an Android-specific tag.Jun 18 2018, 10:57 PM
• Mholloway raised the priority of this task from Medium to Needs Triage.Jun 29 2018, 3:23 PM
• Mholloway moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
• Jhernandez triaged this task as High priority.Jun 29 2018, 5:27 PM
• Jhernandez closed subtask T197174: Tag edits made in iOS app with an iOS-specific tag as Resolved.
• Jhernandez closed subtask T197175: Tag edits made in Android app with an Android-specific tag as Resolved.Jun 29 2018, 5:29 PM
• Jhernandez subscribed.

@Mholloway did you see Lego's feedback? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileApp/+/440969/3/MobileApp.hooks.php#47

Are we fixing that?

• Mholloway added a comment.Jun 29 2018, 6:42 PM

@Jhernandez I was leaving that for @Dbrant to address (or not). The patch works. (https://en.wikipedia.org/w/index.php?title=User%3AMhollo%2Fsandbox&type=revision&diff=848090264&oldid=800823787) I can update if it's a priority.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 1:01 PM
• Vvjjkkii reopened subtask T197175: Tag edits made in Android app with an Android-specific tag as Open.Jul 1 2018, 1:04 AM
• Vvjjkkii reopened subtask T197174: Tag edits made in iOS app with an iOS-specific tag as Open.
• Vvjjkkii renamed this task from Provide separate edit tags for Android and iOS apps to n6caaaaaaa.Jul 1 2018, 1:10 AM
• Vvjjkkii removed • Mholloway as the assignee of this task.
• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii edited subscribers, added: • Mholloway; removed: gerritbot.
CommunityTechBot renamed this task from n6caaaaaaa to Provide separate edit tags for Android and iOS apps.Jul 2 2018, 4:40 PM
CommunityTechBot assigned this task to • Mholloway.
CommunityTechBot closed subtask T197174: Tag edits made in iOS app with an iOS-specific tag as Resolved.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot closed subtask T197175: Tag edits made in Android app with an Android-specific tag as Resolved.
CommunityTechBot edited subscribers, added: gerritbot; removed: • Mholloway.
• Jhernandez closed this task as Resolved.Jul 3 2018, 12:47 PM
• chelsyx mentioned this in T201062: Load change tags into the Analytics Data Lake on a daily basis.Aug 2 2018, 6:47 PM
Xiplus mentioned this in T203223: Add "Tag-android app edit" and "Tag-ios app edit" to i18n.Aug 31 2018, 8:48 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL