Inspectors are cut off inside dialogs.
To reproduce:
- Cite → Manual → Basic form
- Press Ctrl+K to open link inspector
This is probably a regression from Ed's stuff related to T166217.
matmarex | |
May 10 2018, 9:30 PM |
F18142520: image.png | |
May 10 2018, 9:30 PM |
Inspectors are cut off inside dialogs.
To reproduce:
This is probably a regression from Ed's stuff related to T166217.
Change 433713 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] Fix position of inspectors/context inside dialogs
Change 433713 abandoned by Bartosz Dziewoński:
Fix position of inspectors/context inside dialogs
Reason:
I talked to Ed, and instead of this, we should move the override from #getSurfaceConfig to #addSurface, so it only applies to the "main" surface of the Target rather than all of the surfaces (including those in TargetWidgets).
Change 433717 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Fix position of inspectors/context inside dialogs
Change 433718 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Flow@master] Fix position of inspectors/context inside dialogs
Change 433717 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix position of inspectors/context inside dialogs
Change 433726 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.4] Fix position of inspectors/context inside dialogs
Change 433727 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.3] Fix position of inspectors/context inside dialogs
Change 433718 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Fix position of inspectors/context inside dialogs
Change 433727 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.3] Fix position of inspectors/context inside dialogs
Change 433731 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/extensions/Flow@wmf/1.32.0-wmf.4] Fix position of inspectors/context inside dialogs
Change 433732 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/extensions/Flow@wmf/1.32.0-wmf.3] Fix position of inspectors/context inside dialogs
Change 433726 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.4] Fix position of inspectors/context inside dialogs
Change 433732 abandoned by Bartosz Dziewoński:
Fix position of inspectors/context inside dialogs
Reason:
I think we're not backporting this one, only VE.
Change 433731 abandoned by Bartosz Dziewoński:
Fix position of inspectors/context inside dialogs
Reason:
I think we're not backporting this one, only VE.