| • TBolliger | |
| May 10 2018, 10:25 PM |
| F30047373: Screenshot 2019-08-19 at 12.47.39 PM.png | |
| Aug 19 2019, 7:21 AM |
| F18143157: Screen Shot 2018-05-10 at 3.21.00 PM.png | |
| May 10 2018, 10:25 PM |
When an in-line diff is open, the 'header' for each column is a link to the applicable revision. This can result in accidental clicks.
There's a PR here which is sort of a WIP. https://github.com/wikimedia/InteractionTimeline/pull/108
As I mentioned here, I don't think this change is necessary. It only makes sense if there is more than one link that needs to be displayed, but since there is only a single link I'm not not sure why we'd make this change. To me it's really clear that it's a link by it's hover state and cursor change.
In my beginning work on this, I found the original link target very confusing and did accidentally click on it a few times. So, my experience was the opposite of yours.
Maybe @Prtksxna has some thoughts about it?
I can see how in its current form the target can be confusing. I see two main reasons for this:
I don't want to suggest a solution right now though. Can we revisit this once the initial design changes are done? For the time being we can keep the behavior as it. Would that be ok?
...just came across this - first thought was "Oh hey that's me" in the screenshot above. I agree that the link should be moved, but concur with T194439#5420829 that, if the design is being changes separately, it may be better to wait and revisit this task afterwards.
I don't want to suggest a solution right now though. Can we revisit this once the initial design changes are done? For the time being we can keep the behavior as it. Would that be ok?
Which initial design changes are you referring to? I seem to be missing something.