Page MenuHomePhabricator
Create Task
Maniphest T194440

[beta cluster] Uncaught TypeError: Cannot read property 'lat' of null - when 'Edit layer' option is used.
Closed, ResolvedPublic
Actions

Description

  1. Add a map to a page, e.g.
<mapframe latitude="46.725" longitude="7.668" zoom="8" width="350" height="300" />
  1. In VE open the map for editing. Use options "Draw a polygon" and "Draw a rectangle" to add elements to a map.
  2. When a polygon or a rectangle are added, "Edit layers" option becomes active. Click on it - the error will be displayed:
Uncaught TypeError: Cannot read property 'lat' of null
    at Object.project 
    at Object.latLngToPoint 
    at NewClass.project
    at NewClass._getMiddleLatLng 
    at NewClass._createMiddleMarker 
    at NewClass._initMarkers
    at NewClass.addHooks 
    at NewClass._eachVertexHandler 
    at NewClass.addHooks

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update Leaflet.draw to v1.0.3mediawiki/extensions/Kartographermaster+1 K -446
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.May 10 2018, 11:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 10 2018, 11:04 PM
Liuxinyu970226 added a project: Beta-Cluster-Infrastructure.May 11 2018, 3:41 AM
EddieGP subscribed.May 27 2018, 9:55 AM

Please provice a bit more information on what you were doing, which wiki in beta you specifically used, what part of the software you're refering to or what the 'edit layer' option is. See also https://www.mediawiki.org/wiki/How_to_report_a_bug

Etonkovidova added projects: Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage.May 31 2018, 12:09 AM
Etonkovidova updated the task description. (Show Details)
Restricted Application added a project: Maps. · View Herald TranscriptMay 31 2018, 12:09 AM
Etonkovidova added a comment.May 31 2018, 12:10 AM

@EddieGP - sorry, I didn't realize that I haven't added the content when I was creating the ticket.

Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptMay 31 2018, 12:10 AM
Etonkovidova merged a task: T194443: VE 'Edit layers' - Uncaught TypeError: Cannot read property 'lat' of null.May 31 2018, 8:57 PM
• Vvjjkkii renamed this task from [betalabs] Uncaught TypeError: Cannot read property 'lat' of null - when 'Edit layer' option is used. to 75caaaaaaa.Jul 1 2018, 1:11 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from 75caaaaaaa to [betalabs] Uncaught TypeError: Cannot read property 'lat' of null - when 'Edit layer' option is used. .Jul 2 2018, 4:19 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
• Jhernandez removed a project: Discovery-ARCHIVED.Jul 10 2018, 4:35 PM
• Mholloway triaged this task as Medium priority.Aug 14 2018, 3:22 PM
• Mholloway edited projects, added Maps (Kartographer); removed Collaboration-Team-Triage, Collaboration-Feature-Rollouts (Collaboration-Maps), Maps.
• Mholloway renamed this task from [betalabs] Uncaught TypeError: Cannot read property 'lat' of null - when 'Edit layer' option is used. to [beta cluster] Uncaught TypeError: Cannot read property 'lat' of null - when 'Edit layer' option is used. .Sep 18 2018, 3:40 PM
MSantos moved this task from Unsorted to VisualEditor on the Maps (Kartographer) board.Sep 18 2018, 3:41 PM
matmarex claimed this task.Oct 19 2018, 6:16 AM
matmarex subscribed.

I ran into this issue when working on T203473 and debugged it for a bit. Looks like we're using an old version of Leaflet.draw (0.2.5 with some local hacks) meant for Leaflet 0.7, while we're actually using Leaflet 1.0.2. This bug is fixed by https://github.com/Leaflet/Leaflet.draw/commit/48b8297dd2e39509d84cf5efaf4ee9f3d34252b7 upstream in Leaflet.draw 0.4.0.

gerritbot subscribed.Oct 19 2018, 6:37 AM

Change 468504 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Kartographer@master] Update Leaflet.draw to v1.0.3

https://gerrit.wikimedia.org/r/468504

gerritbot added a project: Patch-For-Review.Oct 19 2018, 6:37 AM
gerritbot added a comment.Oct 19 2018, 10:36 AM

Change 468504 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Update Leaflet.draw to v1.0.3

https://gerrit.wikimedia.org/r/468504

matmarex closed this task as Resolved.Oct 19 2018, 8:26 PM
matmarex edited projects, added VisualEditor; removed Beta-Cluster-Infrastructure.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 19 2018, 8:26 PM
• Petar.petkovic removed a project: Patch-For-Review.Feb 23 2019, 11:49 AM
• Petar.petkovic removed a subscriber: gerritbot.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits