Maniphest T194451

Make the tablesorter CSS not expand the width of unsortable columns
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	TheDJ
	May 11 2018, 7:31 AM

Project Tags

Referenced Files

None

Subscribers

Description

"the headers of the columns with the 'unsortable' attribute are sized just like a sortable column, without the sorting button."

This could easily be improved, if we change the recently added

.client-js table.sortable th {
    padding-right: 21px;
}

into

.client-js table.sortable th:not(.unsortable) {
    padding-right: 21px;
}

Example table: http://reading-web-staging.wmflabs.org/wiki/Help:Sorting#Making_a_column_unsortable

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	tablesorter: be more specific about reserving space for header cells	TheDJ	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Duplicate	None	T257127 "Global account info" looks sortable on mobile but isn't
Resolved	None	T233340 Add sortability to sortable tables for readers of the mobile web site
Resolved	TheDJ	T194451 Make the tablesorter CSS not expand the width of unsortable columns

Event Timeline

TheDJ created this task.May 11 2018, 7:31 AM

TheDJ triaged this task as Medium priority.

RP88 subscribed.May 11 2018, 7:49 AM

Hmm, this also doesn't account for header cells in tfoot.

Change 432599 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/core@master] tablesorter: be more specific about resering space for header cells

https://gerrit.wikimedia.org/r/432599

gerritbot added a project: Patch-For-Review.May 11 2018, 3:26 PM

Zebulon84 subscribed.May 11 2018, 4:35 PM

Jdforrester-WMF renamed this task from Improve tablesorter CSS to take into account unsortable columns to Make the tablesorter CSS not expand the width of unsortable columns.May 11 2018, 6:07 PM

Change 432599 merged by jenkins-bot:
[mediawiki/core@master] tablesorter: be more specific about reserving space for header cells

https://gerrit.wikimedia.org/r/432599

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)).May 19 2018, 11:01 AM

• matmarex closed this task as Resolved.May 28 2018, 9:11 PM

• matmarex assigned this task to TheDJ.

• Vvjjkkii renamed this task from Make the tablesorter CSS not expand the width of unsortable columns to w5caaaaaaa.Jul 1 2018, 1:10 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed TheDJ as the assignee of this task.

• Vvjjkkii raised the priority of this task from Medium to High.