Maniphest T194476

Articles in the "for later" list should be shown regardless of language selection for translation suggestions
Closed, ResolvedPublic
Actions

Description

The translation dashboard allows users to keep translations for later. The "for later" list is intended to show all the articles the user saved there.

Currently, the articles show depend on the language selector from the suggestions list, which is unexpected since those lists are represented as separate elements. The issue is illustrated below:


"Bhojpuri cuisine" is in the "For later" list initially as suggestions for Spanish are shown.	After I select suggestions to show for Basque, the "For later" list disappears.

The expected behaviour is for the "For later" list to show all articles that were kept for later regardless of the current language selection made for the suggestions list.

Details

Project	Branch	Lines +/-	Subject
mediawiki/extensions/ContentTranslation	master	+2 -1	Keep for later list upon language pair change
mediawiki/extensions/ContentTranslation	master	+4 -0	Keep newly favorited articles after changing language pair
mediawiki/extensions/ContentTranslation	master	+34 -35	Always show the list of favorite articles

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T76456 Language Engineering tracker of trackers (tracking)
Open	None	T127695 Design polishing for Content Translation
Resolved	• Petar.petkovic	T194476 Articles in the "for later" list should be shown regardless of language selection for translation suggestions

Event Timeline

Pginer-WMF triaged this task as Medium priority.May 11 2018, 10:08 AM

Pginer-WMF created this task.

Pginer-WMF moved this task from Needs Triage to Bugs on the ContentTranslation board.

Pginer-WMF moved this task from Bugs to Translation List on the ContentTranslation board.

Pginer-WMF mentioned this in T195760: Language Annual Plan 2018-2019.May 28 2018, 11:39 AM

Arrbee edited projects, added CX-TranslationList; removed ContentTranslation.Jun 25 2018, 12:04 PM

• Vvjjkkii renamed this task from Articles in the "for later" list should be shown regardless of language selection for translation suggestions to 74caaaaaaa.Jul 1 2018, 1:10 AM

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from 74caaaaaaa to Articles in the "for later" list should be shown regardless of language selection for translation suggestions.Jul 2 2018, 5:50 AM

CommunityTechBot lowered the priority of this task from High to Medium.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

Pginer-WMF added a project: Language-Team (Language-2019-July-September).Jun 5 2019, 10:56 AM

Pginer-WMF moved this task from Backlog to Priority backlog on the Language-Team (Language-2019-July-September) board.Jul 29 2019, 11:22 AM

Change 528249 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Always show the list of favorite articles

https://gerrit.wikimedia.org/r/528249

gerritbot added a project: Patch-For-Review.Aug 5 2019, 7:52 PM

• Petar.petkovic claimed this task.Aug 5 2019, 7:52 PM

• Petar.petkovic moved this task from Priority backlog to In Review on the Language-Team (Language-2019-July-September) board.

@Pginer-WMF should all articles (in all language pairs) added to favorites be showing? The list can potentially be very big.
We employ paging for other lists (In progress and published), but that can hardly work when we need to show suggestions on the same view.

Change 528249 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Always show the list of favorite articles

https://gerrit.wikimedia.org/r/528249

• Petar.petkovic moved this task from In Review to Needs QA on the Language-Team (Language-2019-July-September) board.Aug 13 2019, 7:38 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 13 2019, 8:11 AM

2 issues found:

*the list disappears when you change the language*

go to the cx tool
go to suggestions page
clean the for later list
reload the page
add a few articles to the list
change the from language of the suggested pages

the list disappears

*an error occurs when you delete an article from the list*

go to the cx tool
go to suggestions page
clean the for later list
reload the page
add a few articles to the list
change the from language of the suggested pages
remove an item from the for later list

if you then add an article this happens

it seems that it tries to create a new list instead of adding another item to the existing list

Change 530779 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Keep newly favorited articles after changing language pair

https://gerrit.wikimedia.org/r/530779

gerritbot added a project: Patch-For-Review.Aug 18 2019, 5:59 PM

Change 530780 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Keep for later list upon language pair change

https://gerrit.wikimedia.org/r/530780

• Petar.petkovic moved this task from In Progress to In Review on the Language-Team (Language-2019-July-September) board.Aug 18 2019, 6:15 PM

In T194476#5398906, @Petar.petkovic wrote:

@Pginer-WMF should all articles (in all language pairs) added to favorites be showing? The list can potentially be very big.
We employ paging for other lists (In progress and published), but that can hardly work when we need to show suggestions on the same view.

The "for later" list has the potential to become a long list. Given that these items represent topics the user is interested in translating and the user has direct control on them, I'm not concerned about the list becoming too prominent.

Making the list to include the different languages is not expected to aggravate the issue significantly. But it would be good to measure to better understand how often the list is growing too large to be useful.

Change 530779 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Keep newly favorited articles after changing language pair

https://gerrit.wikimedia.org/r/530779

Change 530780 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Keep for later list upon language pair change

https://gerrit.wikimedia.org/r/530780

• Petar.petkovic removed a project: Patch-For-Review.Aug 20 2019, 8:46 AM

• Petar.petkovic moved this task from In Review to Needs QA on the Language-Team (Language-2019-July-September) board.

Jpita moved this task from Needs QA to Recheck after deployment on the Language-Team (Language-2019-July-September) board.Aug 20 2019, 10:57 AM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 20 2019, 6:01 PM

Jpita closed this task as Resolved.Aug 26 2019, 12:50 PM

Jpita moved this task from Recheck after deployment to Done on the Language-Team (Language-2019-July-September) board.

Pginer-WMF added a project: CX-boost.Aug 30 2019, 8:59 AM

Jpita mentioned this in T188634: Allow to keep for later any article selected in the new translation dialog.Oct 21 2019, 7:05 AM