Page MenuHomePhabricator
Create Task
Maniphest T194502

Only allow moves of files that have one of the required templates
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Acceptance Criteria

  • Check if the move candidate's file page contains on of the required templates (describes as "Templates/good" in the appropriate config file)
  • If it does contain one of the required templates, proceed to displaying the Special:Import page without any information to the user
  • If it does not contain any of the required templates, please proceed to the error page with the error: The file cannot be imported, because it is not marked with one of the required licences.
  • If there is no section "templates/good" in the config file, please also proceed to the error page with the error: The configuration file for your wiki (linking to the config file) does not contain enough info about <problem e.g. Template or Template/Good> to know if this file can be put on Commons
  • The template names should be case-independent (lowercase matches uppercase)

Notes

  • Probably the same regex as in T194129, only other names and strings

Details

SubjectRepoBranchLines +/-
Enable license filters for the FileImporter in productionoperations/mediawiki-configmaster+1 -0
Remove sentence asking to "add a license"mediawiki/extensions/FileImportermaster+1 -1
Allow file to be moved if it contains at least one of the required templatesmediawiki/extensions/FileImportermaster+167 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lea_WMDE created this task.May 11 2018, 1:24 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptMay 11 2018, 1:24 PM
Lea_WMDE triaged this task as Medium priority.May 11 2018, 1:24 PM
Lea_WMDE set the point value for this task to 3.
Lea_WMDE updated the task description. (Show Details)
Lea_WMDE mentioned this in T189570: Show meaningful error messages if import fails.
thiemowmde moved this task from Incoming to Move files to Commons on the TCB-Team (now WMDE-TechWish) board.May 11 2018, 5:04 PM
• Hanna_Petruschat_WMDE updated the task description. (Show Details)May 14 2018, 8:33 AM
thiemowmde added a parent task: T193614: Reuse Commonhelper2's config files for category and template matching.May 30 2018, 10:39 AM
Tobi_WMDE_SW added a project: WMDE-QWERTY-Sprint-2018-06-05.Jun 5 2018, 1:12 PM
Tobi_WMDE_SW moved this task from Tickets ready for pickup to Tickets in sprint on the Move-Files-To-Commons board.Jun 5 2018, 2:22 PM
Andrew-WMDE claimed this task.Jun 6 2018, 8:38 AM
Andrew-WMDE moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-06-05 board.
gerritbot added a subscriber: gerritbot.Jun 6 2018, 9:57 AM

Change 437704 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/FileImporter@master] Allow file to be moved if it contains at least one of the required templates

https://gerrit.wikimedia.org/r/437704

gerritbot added a project: Patch-For-Review.Jun 6 2018, 9:57 AM
Andrew-WMDE mentioned this in rEFLIfa298f4a8614: Allow file to be moved if it contains at least one of the required templates.Jun 6 2018, 10:03 AM
Andrew-WMDE mentioned this in rEFLI2b1cdc343636: Allow file to be moved if it contains at least one of the required templates.
Andrew-WMDE moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2018-06-05 board.Jun 6 2018, 10:06 AM
Andrew-WMDE mentioned this in rEFLI10421ea5aa94: Allow file to be moved if it contains at least one of the required templates.Jun 6 2018, 1:14 PM
gerritbot added a comment.Jun 6 2018, 2:08 PM

Change 437704 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Allow file to be moved if it contains at least one of the required templates

https://gerrit.wikimedia.org/r/437704

Andrew-WMDE moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2018-06-05 board.Jun 6 2018, 2:32 PM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)).Jun 6 2018, 3:01 PM
WMDE-Fisch added a subscriber: WMDE-Fisch.Jun 11 2018, 12:03 PM

To tests: I configured https://mwfileimport.wmflabs.org/wiki/index.php/Special:ImportFile so it can be used with the CommonsHelper2 config files.

WMDE-Fisch mentioned this in T194132: Parse the file info wikitext to forbid files with a wrong licence.Jun 11 2018, 12:05 PM
Lea_WMDE updated the task description. (Show Details)Jun 12 2018, 10:07 AM
gerritbot added a comment.Jun 12 2018, 10:08 AM

Change 439867 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Remove sentence asking to "add a license"

https://gerrit.wikimedia.org/r/439867

gerritbot added a comment.Jun 12 2018, 10:18 AM

Change 439867 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Remove sentence asking to "add a license"

https://gerrit.wikimedia.org/r/439867

thiemowmde mentioned this in rEFLI2544d048d39a: Remove sentence asking to "add a license".Jun 12 2018, 10:18 AM
gerritbot added a comment.Jun 18 2018, 1:56 PM

Change 440864 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[operations/mediawiki-config@master] Enable license filters for the FileImporter in production

https://gerrit.wikimedia.org/r/440864

gerritbot added a comment.Jun 25 2018, 2:21 PM

Change 440864 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable license filters for the FileImporter in production

https://gerrit.wikimedia.org/r/440864

Stashbot added a subscriber: Stashbot.Jun 25 2018, 2:23 PM

Mentioned in SAL (#wikimedia-operations) [2018-06-25T14:23:53Z] <addshore@deploy1001> Synchronized wmf-config/CommonSettings.php: [[gerrit:440864|Enable license filters for the FileImporter in production]] T194502 (duration: 00m 55s)

• Vvjjkkii renamed this task from Only allow moves of files that have one of the required templates to h4caaaaaaa.Jul 1 2018, 1:11 AM
• Vvjjkkii removed Andrew-WMDE as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail.
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed the point value for this task.
• Vvjjkkii edited subscribers, added: Andrew-WMDE; removed: gerritbot.
Bodhisattwa renamed this task from h4caaaaaaa to Only allow moves of files that have one of the required templates.Jul 1 2018, 2:12 PM
Bodhisattwa assigned this task to Andrew-WMDE.
Bodhisattwa lowered the priority of this task from High to Medium.
Bodhisattwa removed projects: Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Bodhisattwa updated the task description. (Show Details)
Lea_WMDE closed this task as Resolved.Jul 3 2018, 12:20 PM
CommunityTechBot set the point value for this task to 3.Jul 5 2018, 6:41 PM
CommunityTechBot updated the task description. (Show Details)
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 2:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL