Maniphest T194517

Ingenico We don't have an order status after doing a GET_ORDERSTATUS.
Closed, ResolvedPublic
Actions

Description

Result of the first 1-hour test. Some transactions reporting an error with the message 'We don't have an order status after doing a GET_ORDERSTATUS.'

Details

	Subject	Repo	Branch	Lines +/-
	Handle no status code for Ingenico api	mediawiki/extensions/DonationInterface	master	+35 -2
	Refactor of ConfirmCreditCard to handle pending flag	mediawiki/extensions/DonationInterface	master	+85 -85

Customize query in gerrit

Event Timeline

XenoRyet created this task.May 11 2018, 4:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 11 2018, 4:57 PM

• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.May 14 2018, 7:40 PM

• DStrine moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.May 22 2018, 8:33 PM

• DStrine added a project: Fundraising Sprint Karma chameleons hide amongst us.May 22 2018, 8:42 PM

XenoRyet claimed this task.May 29 2018, 10:22 PM

XenoRyet moved this task from Backlog to Doing on the Fundraising Sprint Karma chameleons hide amongst us board.

XenoRyet moved this task from Doing to Backlog on the Fundraising Sprint Karma chameleons hide amongst us board.Jun 4 2018, 7:43 PM

XenoRyet removed XenoRyet as the assignee of this task.Jun 5 2018, 8:23 PM

• DStrine added a project: Fundraising Sprint Lactose is unusually tolerant.Jun 5 2018, 8:33 PM

Hmm just beginning to look into this, but could it be that we're getting a different statuscode than globalcollect expects? I'll see if I can reproduce.

So far I can't reproduce. I'll take a closer look at the logs.

Hmm this is what I see, the curl response seems to be: {"status":"IN_PROGRESS"}, which is why we can't get a status out of it.

Oh! So it looks like when a payment is in progress, there is no status code: https://epayments-api.developer-ingenico.com/s2sapi/v1/en_US/java/statuses.html. I'll need to add handling.

• mepps claimed this task.Jun 14 2018, 3:22 PM

Change 440465 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/extensions/DonationInterface@master] WIP: Handle no status code for Ingenico api

https://gerrit.wikimedia.org/r/440465

gerritbot added a project: Patch-For-Review.Jun 14 2018, 9:03 PM

• DStrine added a project: Fundraising Sprint Matt Damon to head up Space Force.Jun 18 2018, 8:21 PM

• Vvjjkkii renamed this task from Ingenico We don't have an order status after doing a GET_ORDERSTATUS. to 23caaaaaaa.Jul 1 2018, 1:11 AM

• Vvjjkkii removed • mepps as the assignee of this task.

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

jgleeson renamed this task from 23caaaaaaa to Ingenico We don't have an order status after doing a GET_ORDERSTATUS..Jul 2 2018, 12:58 PM

jgleeson assigned this task to • mepps.

jgleeson raised the priority of this task from High to Needs Triage.

jgleeson removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser, Fundraising Sprint Matt Damon to head up Space Force.

jgleeson updated the task description. (Show Details)

jgleeson edited subscribers, added: Aklapper; removed: • mepps.

Change 444311 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/extensions/DonationInterface@master] WIP Refactor of ConfirmCreditCard

https://gerrit.wikimedia.org/r/444311

• DStrine added a project: Fundraising Sprint Naming Sprints Is Not Important.Jul 11 2018, 9:26 PM

Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Naming Sprints Is Not Important board.Jul 12 2018, 3:12 PM

• DStrine added a project: Fundraising Sprint Owls.Jul 24 2018, 8:14 PM

Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Owls board.Jul 30 2018, 10:39 PM

• DStrine added a project: Fundraising Sprint Pluto is still a planet.Aug 7 2018, 8:42 PM

Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Pluto is still a planet board.Aug 7 2018, 9:13 PM

Change 444311 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Refactor of ConfirmCreditCard to handle pending flag

https://gerrit.wikimedia.org/r/444311

Change 440465 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Handle no status code for Ingenico api

https://gerrit.wikimedia.org/r/440465

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 9 2018, 11:00 PM

Ejegg moved this task from Doing to Pending Deployment on the Fundraising Sprint Pluto is still a planet board.Aug 9 2018, 11:18 PM

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Pluto is still a planet board.Aug 10 2018, 4:14 AM

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 14 2018, 8:55 PM

• DStrine added a project: Fundraising Sprint Queue is pronounced GJif.Aug 21 2018, 8:47 PM

Ejegg closed this task as Resolved.Aug 22 2018, 1:05 AM

Ejegg triaged this task as Medium priority.

Ejegg moved this task from Backlog to Campaign ready on the Fr-Ingenico-integration_2017-18 board.

Ejegg removed a project: Fundraising Sprint Queue is pronounced GJif.

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)); removed MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).Aug 31 2018, 3:00 PM

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)); removed MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Sep 28 2018, 5:00 PM

Ingenico We don't have an order status after doing a GET_ORDERSTATUS.Closed, ResolvedPublicActions

Description

Details

Event Timeline

Ingenico We don't have an order status after doing a GET_ORDERSTATUS.
Closed, ResolvedPublic
Actions