Page MenuHomePhabricator
Create Task
Maniphest T194616

Undefined offset when given ​​other than 0 and 1 value for hide_tag_log parameter
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:
Given ​​other than 0 and 1 value for hide_tag_log parameter on a log page. E.g. https://dev.razesoldier.cn/w/index.php?title=Special:Log&hide_tag_log=2, this page shows

PHP Notice:  Undefined offset: -1 in mediawiki/w/includes/logging/LogEventsList.php on line 185

Current version: 1.31.0-rc.0 (b05a169)

Details

SubjectRepoBranchLines +/-
Prevent "Undefined offset notice"mediawiki/coremaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

RazeSoldier created this task.May 14 2018, 1:24 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 14 2018, 1:24 AM
RazeSoldier added a project: MediaWiki-General.May 14 2018, 1:30 AM
Aklapper edited projects, added MediaWiki-Logevents; removed MediaWiki-General.May 14 2018, 8:57 AM
gerritbot subscribed.Jun 8 2018, 1:36 PM

Change 438244 had a related patch set (by Matěj Suchánek) published:
[mediawiki/core@master] Prevent "Undefined offset notice"

https://gerrit.wikimedia.org/r/438244

gerritbot added a project: Patch-For-Review.Jun 8 2018, 1:36 PM
matej_suchanek claimed this task.Jun 8 2018, 1:36 PM
Krinkle subscribed.EditedJun 8 2018, 2:06 PM

@RazeSoldier Was there a link to "hide_tag_log=2" somewhere in the interface, or was this link manually created in the address bar?

If this is not an accident, then what is "2" supposed to do?

Krinkle added subscribers: Samwilson, kaldari.Jun 8 2018, 2:14 PM
RazeSoldier added a comment.Jun 8 2018, 3:26 PM
In T194616#4267108, @Krinkle wrote:

@RazeSoldier Was there a link to "hide_tag_log=2" somewhere in the interface, or was this link manually created in the address bar?

If this is not an accident, then what is "2" supposed to do?

In fact, my bug detector found this notice. So, generally speaking, this notice will not be triggered by user.

RazeSoldier added a comment.Jun 8 2018, 4:50 PM

I don't know what the detection logic of my detector is because it is closed source. But I don't think there is a link to "hide_tag_log=2" on mediawiki.

gerritbot added a comment.Jun 29 2018, 7:34 PM

Change 438244 merged by jenkins-bot:
[mediawiki/core@master] Prevent "Undefined offset notice"

https://gerrit.wikimedia.org/r/438244

matmarex closed this task as Resolved.Jun 29 2018, 7:37 PM
matmarex removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 8:01 PM
• Vvjjkkii renamed this task from Undefined offset when given ​​other than 0 and 1 value for hide_tag_log parameter to b1caaaaaaa.Jul 1 2018, 1:10 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed matej_suchanek as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii edited subscribers, added: matej_suchanek; removed: gerritbot, Aklapper.
CommunityTechBot renamed this task from b1caaaaaaa to Undefined offset when given ​​other than 0 and 1 value for hide_tag_log parameter.Jul 2 2018, 4:14 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to matej_suchanek.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot edited subscribers, added: gerritbot, Aklapper; removed: matej_suchanek.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits