Maniphest T194620

Fix failing unit tests
Closed, ResolvedPublic16 Estimated Story Points
Actions

Assigned To

Authored By

	Sebastian_Berlin-WMSE
	May 14 2018, 7:10 AM

Description

Fix the mess that has become of 428393. This started as a patch to switch QUnit package (which may not be the case any more), but has led to several unit test failures. It's unclear how these are related to the QUnit upgrade, but they need to be solved nonetheless.

Some problems have been fixed, such as tests testing the wrong things (like behaviour of HTMLMediaElement) and things not resetting properly between tests. There are still some issues remaining concerning Ajax requests (possibly with race conditions) and audio playback.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Wikispeech	REL1_31	+80 -90	tests: Fix QUnit failures due to pending ajax requests
	mediawiki/extensions/Wikispeech	master	+80 -90	tests: Fix QUnit failures due to pending ajax requests

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Sebastian_Berlin-WMSE	T194620 Fix failing unit tests
		Resolved		hashar	T197687 Wikispeech QUnit tests fail with Chrome 66: play() failed because the user didn't interact with the document first.

Event Timeline

Sebastian_Berlin-WMSE created this task.May 14 2018, 7:10 AM

Sebastian_Berlin-WMSE set the point value for this task to 16.

Sebastian_Berlin-WMSE moved this task from This Week to Backlog on the User-Sebastian_Berlin-WMSE board.May 28 2018, 8:42 AM

Sebastian_Berlin-WMSE moved this task from Backlog to This Week on the User-Sebastian_Berlin-WMSE board.Jun 12 2018, 6:45 AM

Change 428393 had a related patch set uploaded (by Sebastian Berlin (WMSE); owner: Jforrester):
[mediawiki/extensions/Wikispeech@master] tests: Fix QUnit failures due to pending ajax requests

https://gerrit.wikimedia.org/r/428393

gerritbot added a project: Patch-For-Review.Jun 12 2018, 1:07 PM

Sebastian_Berlin-WMSE mentioned this in rEWIS974fce375533: tests: Fix QUnit failures due to pending ajax requests.Jun 12 2018, 1:15 PM

Lokal_Profil mentioned this in rEWISe5e1dd6a533b: tests: Fix QUnit failures due to pending ajax requests.Jun 19 2018, 9:15 AM

Lokal_Profil mentioned this in rEWIS457f54e242eb: tests: Fix QUnit failures due to pending ajax requests.

Lokal_Profil mentioned this in rEWISe89063f8f906: tests: Fix QUnit failures due to pending ajax requests.Jun 19 2018, 11:19 AM

Lokal_Profil mentioned this in rEWISc168aa7acf9f: tests: Fix QUnit failures due to pending ajax requests.Jun 19 2018, 11:35 AM

Change 428393 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] tests: Fix QUnit failures due to pending ajax requests

https://gerrit.wikimedia.org/r/428393

Merged. Great work @Sebastian_Berlin-WMSE

hashar mentioned this in T197687: Wikispeech QUnit tests fail with Chrome 66: play() failed because the user didn't interact with the document first..Jun 19 2018, 2:26 PM

hashar closed subtask T197687: Wikispeech QUnit tests fail with Chrome 66: play() failed because the user didn't interact with the document first. as Resolved.Jun 22 2018, 5:17 PM

• Vvjjkkii reopened subtask T197687: Wikispeech QUnit tests fail with Chrome 66: play() failed because the user didn't interact with the document first. as Open.Jul 1 2018, 1:02 AM

• Vvjjkkii renamed this task from Fix failing unit tests to 70caaaaaaa.Jul 1 2018, 1:10 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed Sebastian_Berlin-WMSE as the assignee of this task.

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed the point value for this task.

• Vvjjkkii removed a subscriber: gerritbot.

CommunityTechBot closed subtask T197687: Wikispeech QUnit tests fail with Chrome 66: play() failed because the user didn't interact with the document first. as Resolved.Jul 2 2018, 1:28 PM

CommunityTechBot renamed this task from 70caaaaaaa to Fix failing unit tests.Jul 2 2018, 4:13 PM

CommunityTechBot closed this task as Resolved.

CommunityTechBot assigned this task to Sebastian_Berlin-WMSE.

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot set the point value for this task to 16.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: gerritbot.

Mentioned in SAL (#wikimedia-cloud) [2018-07-20T10:08:54Z] <sebastian-wmse> Deploy latest (v0.1.0) from Git master: 2a79cdd, 7522a46, c168aa7 (T194620), c201912; update MediaWiki to b8dee03

Change 653742 had a related patch set uploaded (by Legoktm; owner: Jforrester):
[mediawiki/extensions/Wikispeech@REL1_31] tests: Fix QUnit failures due to pending ajax requests

https://gerrit.wikimedia.org/r/653742

gerritbot added a project: Patch-For-Review.Jan 3 2021, 7:04 PM

Change 653742 merged by Umherirrender:
[mediawiki/extensions/Wikispeech@REL1_31] tests: Fix QUnit failures due to pending ajax requests

https://gerrit.wikimedia.org/r/653742

Legoktm mentioned this in rEWIS300f66c4d254: tests: Fix QUnit failures due to pending ajax requests.Jan 3 2021, 7:09 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 3 2021, 7:10 PM