Page MenuHomePhabricator
Create Task
Maniphest T194622

MenuTagMultiselectWidget: `draggable: false` doesn't do anything
Closed, DeclinedPublic
Actions

Description

Steps to reproduce:

  1. Go to https://doc.wikimedia.org/oojs-ui/master/js/#!/api/OO.ui.MenuTagMultiselectWidget
  2. Edit the example to include draggable: false in the config for the MenuTagMultiselectWidget constructor
  3. Go to the preview.
  4. Drag an item.

Expected:
The item should not be draggable.

Actual:
It is.

Related Objects
Search...

Event Timeline

Schnark created this task.May 14 2018, 7:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 14 2018, 7:50 AM
Volker_E moved this task from Backlog to Next-up on the OOUI board.Jun 4 2018, 11:54 PM
Volker_E triaged this task as Low priority.Jun 13 2018, 2:18 PM
Volker_E added a parent task: T158400: Streamline & improve tag component TagMultiselectWidget (former CapsuleMultiselectWidget).Jun 13 2018, 2:35 PM
Volker_E renamed this task from draggable: false doesn't do anything for MenuTagMultiselectWidget to MenuTagMultiselectWidget: `draggable: false` doesn't do anything.Jun 13 2018, 2:44 PM
• Vvjjkkii renamed this task from MenuTagMultiselectWidget: `draggable: false` doesn't do anything to 50caaaaaaa.Jul 1 2018, 1:10 AM
• Vvjjkkii raised the priority of this task from Low to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from 50caaaaaaa to MenuTagMultiselectWidget: `draggable: false` doesn't do anything.Jul 2 2018, 3:39 PM
CommunityTechBot lowered the priority of this task from High to Low.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
Volker_E moved this task from Next-up to Backlog on the OOUI board.Sep 9 2022, 11:31 PM
matmarex closed this task as Declined.Jan 9 2025, 12:20 AM
matmarex subscribed.

I think this is the expected behavior – draggable: false only applies to the MenuTagMultiselectWidget, and not the the internal TagItemWidgets, so they're still draggable (but dragging them doesn't do anything, because the parent multiselect widget is not draggable, and doesn't allow dropping them).

I think what you actually want is allowReordering: false. Which currently also doesn't do anything, but that's a bug, and I'm fixing it in https://gerrit.wikimedia.org/r/c/oojs/ui/+/1109174. (Or you can override addTag() and make each tag item non-draggable there.)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits