Page MenuHomePhabricator
Create Task
Maniphest T194631

Canceling section edit in NWE takes you to start of page
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Find a long article, scroll down to some section.
  2. Edit in NWE.
  3. Cancel your edit by pressing ESC.

Expected:
You return to read mode, with scroll state either exactly as before your edit or with the section you edited on top.

Actual:
You return to the start of the whole page.

Details

SubjectRepoBranchLines +/-
DesktopArticleTarget: Section-scroll as part of restoring the pagemediawiki/extensions/VisualEditormaster+6 -18
Customize query in gerrit

Event Timeline

Schnark created this task.May 14 2018, 9:04 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptMay 14 2018, 9:04 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Cirdan subscribed.May 14 2018, 12:36 PM
Esanders triaged this task as Low priority.May 14 2018, 4:15 PM
Dvorapa subscribed.May 14 2018, 7:50 PM
gerritbot subscribed.May 25 2018, 4:33 PM

Change 435190 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget: Section-scroll as part of restoring the page

https://gerrit.wikimedia.org/r/435190

gerritbot added a project: Patch-For-Review.May 25 2018, 4:33 PM
DLynch claimed this task.May 29 2018, 2:46 PM
DLynch edited projects, added VisualEditor (Current work); removed VisualEditor.
DLynch moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.May 30 2018, 10:03 PM

Change 435190 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget: Section-scroll as part of restoring the page

https://gerrit.wikimedia.org/r/435190

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).May 30 2018, 11:00 PM
Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.May 31 2018, 12:39 AM
Jdforrester-WMF removed a project: Patch-For-Review.
• Deskana closed this task as Resolved.May 31 2018, 9:50 AM
Ryasmeen added a project: Verified.Jun 5 2018, 11:09 PM
Jdforrester-WMF set the point value for this task to 1.Jun 13 2018, 6:24 PM
• Vvjjkkii renamed this task from Canceling section edit in NWE takes you to start of page to w0caaaaaaa.Jul 1 2018, 1:10 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed DLynch as the assignee of this task.
• Vvjjkkii raised the priority of this task from Low to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed the point value for this task.
• Vvjjkkii edited subscribers, added: DLynch; removed: gerritbot, Aklapper.
Koavf renamed this task from w0caaaaaaa to Canceling section edit in NWE takes you to start of page.Jul 1 2018, 6:30 PM
JJMC89 closed this task as Resolved.Jul 1 2018, 6:34 PM
JJMC89 assigned this task to DLynch.
JJMC89 lowered the priority of this task from High to Low.
JJMC89 removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
JJMC89 updated the task description. (Show Details)
JJMC89 edited subscribers, added: Aklapper; removed: DLynch.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL