Page MenuHomePhabricator
Create Task
Maniphest T194642

Add "Show changes" to SpecialPage:ImportFile
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Motivation
The FileImporter will try to change templates based on the CommonsHelper2's config files. Right now, users wouldn't be able to see a diff of what changed until after they did the import.

Task

  • Add a "Show changes" button next to the import link on the preview page, in accordance of how it usually looks on article pages, see screenshot

Bildschirmfoto 2018-05-14 um 12.10.18.png (110×1 px, 22 KB)

  • When the button is clicked, show a diff between what the file info was before the import, and now. Remember that this is the no-js version. The diff should also have a button "back to preview"

Details

SubjectRepoBranchLines +/-
Add page to show changes to the imported textmediawiki/extensions/FileImportermaster+262 -2
Customize query in gerrit

Related Objects

Event Timeline

Lea_WMDE created this task.May 14 2018, 10:40 AM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptMay 14 2018, 10:40 AM
Lea_WMDE updated the task description. (Show Details)May 29 2018, 1:54 PM
Lea_WMDE set the point value for this task to 5.
Lea_WMDE moved this task from Tickets in preparation/investigation to Tickets ready for pickup on the Move-Files-To-Commons board.May 30 2018, 10:59 AM
thiemowmde moved this task from Incoming to Move files to Commons on the TCB-Team (now WMDE-TechWish) board.Jun 12 2018, 4:03 PM
Tobi_WMDE_SW renamed this task from Add "Show changes" to SpecialPage:Import to Add "Show changes" to SpecialPage:ImportFile.Jun 19 2018, 10:35 AM
Tobi_WMDE_SW added a project: WMDE-QWERTY-Sprint-2018-06-19.Jun 19 2018, 12:54 PM
Tobi_WMDE_SW moved this task from Tickets ready for pickup to Tickets in sprint on the Move-Files-To-Commons board.Jun 19 2018, 12:58 PM
WMDE-Fisch claimed this task.Jun 19 2018, 4:24 PM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-06-19 board.
WMDE-Fisch added subscribers: • Hanna_Petruschat_WMDE, Charlie_WMDE.Jun 20 2018, 10:29 AM

To finish this I have some questions regarding text / layout on the diff page. Currently it looks like this:

Screenshot-2018-6-20 Import file - EnLocalWiki(1).png (618×1 px, 34 KB)

  • Should the button be aligned with something somehow?
  • What little header text should be shown above the two columns?
  • Do we want to have some kind of header? What should it say? ( for most other pages like the edit title and edit file info pages we do not have headers but we might want to? )
  • Do we want to have some kind of intro text? What should it say?

@Hanna_Petruschat_WMDE , @Charlie_WMDE , @Lea_WMDE

WMDE-Fisch added a comment.Jun 20 2018, 10:32 AM

Also: should the Show changes button show if there are no changes visible?

gerritbot subscribed.Jun 20 2018, 11:08 AM

Change 441190 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/FileImporter@master] [WIP] Add page to show changes to the imported text

https://gerrit.wikimedia.org/r/441190

gerritbot added a project: Patch-For-Review.Jun 20 2018, 11:08 AM
WMDE-Fisch mentioned this in rEFLIc0e5029f6b31: [WIP] Add page to show changes to the imported text.Jun 20 2018, 11:10 AM
thiemowmde subscribed.Jun 20 2018, 3:05 PM

My take on these questions:

  • Button alignment looks fine. We can refine it any time later, if needed.
  • When editing a file description page, the headers say "Latest revision" (message key currentrev) and "Your text" (yourtext). I would reuse these messages for consistency with what the user expects, and because these messages are actually accurate, I believe.
  • I would not add any more headers or intro for now, but wait for the first user tests.
Lea_WMDE added a comment.Jun 21 2018, 6:26 AM

seconding @thiemowmde on his thoughts :)

WMDE-Fisch mentioned this in rEFLI39141a87496a: [WIP] Add page to show changes to the imported text.Jun 22 2018, 8:45 AM
WMDE-Fisch mentioned this in rEFLI4daa6fe2a765: Add page to show changes to the imported text.Jun 22 2018, 10:01 AM
WMDE-Fisch added a comment.Jun 22 2018, 10:05 AM
In T194642#4302152, @WMDE-Fisch wrote:

Also: should the Show changes button show if there are no changes visible?

@Lea_WMDE I was talking to @thiemowmde about that and we agreed ( if I recall correctly ) on not showing the Show changes when no changes where made ( also the summary is not showing then ) - do you agree?

WMDE-Fisch mentioned this in rEFLI41ce7df2c916: Add page to show changes to the imported text.Jun 22 2018, 10:07 AM
WMDE-Fisch mentioned this in rEFLI31a1a8fdba81: Add page to show changes to the imported text.Jun 22 2018, 10:11 AM
WMDE-Fisch moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2018-06-19 board.Jun 22 2018, 10:29 AM
WMDE-Fisch mentioned this in rEFLI9d1b1e7033e3: Add page to show changes to the imported text.Jun 22 2018, 2:25 PM
Lea_WMDE added a comment.Jun 25 2018, 7:06 AM

@WMDE-Fisch sounds good!

thiemowmde mentioned this in rEFLIcec3f2f0d121: Add page to show changes to the imported text.Jun 25 2018, 3:50 PM
gerritbot added a comment.Jun 25 2018, 4:35 PM

Change 441190 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Add page to show changes to the imported text

https://gerrit.wikimedia.org/r/441190

thiemowmde moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2018-06-19 board.Jun 25 2018, 4:43 PM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 4:01 PM
• Vvjjkkii renamed this task from Add "Show changes" to SpecialPage:ImportFile to l0caaaaaaa.Jul 1 2018, 1:10 AM
• Vvjjkkii removed WMDE-Fisch as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail; removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed the point value for this task.
• Vvjjkkii edited subscribers, added: WMDE-Fisch; removed: gerritbot.
Wong128hk renamed this task from l0caaaaaaa to Add "Show changes" to SpecialPage:ImportFile.Jul 1 2018, 2:38 AM
Wong128hk assigned this task to WMDE-Fisch.
Wong128hk raised the priority of this task from High to Needs Triage.
Wong128hk removed projects: Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Wong128hk updated the task description. (Show Details)
Wong128hk edited subscribers, added: gerritbot; removed: WMDE-Fisch.
Wong128hk subscribed.Jul 1 2018, 2:42 AM

Vvjjkkii removed the point value for this task. << for this, it cannot be undone since don't know what has been removed... Please undo it if you know it. Thank you,

Tobi_WMDE_SW set the point value for this task to 5.Jul 3 2018, 8:09 AM
Lea_WMDE closed this task as Resolved.Jul 3 2018, 12:47 PM
Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2018-06-19 board.
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 2:56 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 7 2022, 3:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL