Page MenuHomePhabricator

Migrate Performance Inspector from GUI to console
Closed, ResolvedPublic

Description

At our June offsite we decided that we should use the console for Performance Inspector, instead of providing a GUI item. See comments for (slightly) more detail.

Event Timeline

Vvjjkkii renamed this task from [For June offsite] Decide on the plan for Performance Inspector to fzcaaaaaaa.Jul 1 2018, 1:09 AM
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from fzcaaaaaaa to [For June offsite] Decide on the plan for Performance Inspector.Jul 2 2018, 4:12 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added a subscriber: Aklapper.

Hmm we missed to write the summary from our meeting: We will re-do the inspector, keep the functionality but instead report it to the console instead. @Imarlier do you have the exact notes what we planned?

@Peter you pretty much said what was in my notes :-)

From our June offsite:

Have an action (similar to Page Information) that will display the parse info
Show image sizes as part of mw.inspect()
Move mw.inspect() function in to new module that contains this console code
Imarlier renamed this task from [For June offsite] Decide on the plan for Performance Inspector to Migrate Performance Inspector from GUI to console.Sep 24 2018, 8:49 PM
Imarlier updated the task description. (Show Details)

Change 593656 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] mediawiki.inspect: Add visual module size report

https://gerrit.wikimedia.org/r/593656

Module size report

Performance Inspector (as currently seen on Beta Cluster, using the "Performance inspector" link in the sidebar).

Screenshot 2020-05-01 at 02.44.08.png (1×1 px, 335 KB)

Below is what the current patch for core implements:

Screenshot 2020-05-01 at 02.44.16.png (1×1 px, 199 KB)

Change 593656 abandoned by Krinkle:
mediawiki.inspect: Add visual module size report

https://gerrit.wikimedia.org/r/593656

Krinkle closed this task as Resolved.EditedSep 9 2022, 7:14 PM
Krinkle claimed this task.

As per change 593656, I'm not sure this actually adds value from a console perspective. It was fun writing, but not so sure now. Maybe the console table suffices?

{F35515247 height=200}