Page MenuHomePhabricator

Default action for Commons search box should be "Search" instead of "Go"
Closed, DeclinedPublic

Description

Author: Abigor

Description:
Hello,

On commons we had a discussion and it ended whit 100 % support. I hope a developer can find the time to remove the GO from out search box so that there search button will be the default one.

The discussion was here:
http://commons.wikimedia.org/wiki/Commons:Village_pump/Archive/2009Feb#Default_our_search_box_to_.22Search.22_instead_of_.22Go.22

Thanks in advance,

Huib

Note, in the meanwhile https://www.mediawiki.org/wiki/Extension:SearchExtraNS was enabled on Commons, but that takes effect only when no exact hit is found for the search.

Local discussions

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 10:27 PM
bzimport set Reference to bz17471.
bzimport added a subscriber: Unknown Object (MLST).

chrisipk wrote:

I added a permanent link so the discussion can be found even after some time has passed.

mike.lifeguard+bugs wrote:

Does anyone know what the configuration variable is for doing this? According to http://www.mediawiki.org/wiki/Manual:Configuration_settings#Search the closest thing is http://www.mediawiki.org/wiki/Manual:$wgUseTwoButtonsSearchForm which does not do what is asked for.

mike.lifeguard+bugs wrote:

(In reply to comment #2)

Does anyone know what the configuration variable is for doing this? According
to http://www.mediawiki.org/wiki/Manual:Configuration_settings#Search the
closest thing is
http://www.mediawiki.org/wiki/Manual:$wgUseTwoButtonsSearchForm which does not
do what is asked for.

Are we sure this is ready for the shell? What setting are they changing to get the requested effect?

There's also bug 18354 which has some support on Commons but got wontfixed.

jeluf wrote:

Now that the Vector skin is in place, this change is no longer necessary => RESOLVED WONTFIX.

jeluf wrote:

Now that the Vector skin is in place, this change is no longer necessary => RESOLVED WONTFIX.

Sure? https://commons.wikimedia.org/wiki/Commons:Village_pump/Proposals#Why_is_the_search_feature_so_bad.3F

the closest thing is http://www.mediawiki.org/wiki/Manual:$wgUseTwoButtonsSearchForm which does not do what is asked for.

As noted in the discussion, that's basically what $wgVectorUseSimpleSearch does now. It's not the end result requested here, but it's a first step which gets us closer.

Nemo_bis raised the priority of this task from Lowest to Medium.
Nemo_bis updated the task description. (Show Details)
gerritbot subscribed.

Change 186916 had a related patch set uploaded (by Nemo bis):
Allow a full text search button on Commons whenever possible

https://gerrit.wikimedia.org/r/186916

Patch-For-Review

I wonder if the SearchExtraNS extension should be "expanded" to also check for the additional namespace in the Go/"exact match" case. There were some recent improvements in search which may make this easier than it was 6 years ago (see also MixedNamespaceSearchSuggestions).

@Nemo_bis what actions are needed to resolve this issue?

@Nemo_bis what actions are needed to resolve this issue?

First, merging the patch above. :)
Then I think a SearchExtraNS patch would not be too hard

Okay, I offer we announce the coming soon UI search behavior change now, and deploy it next Monday.

This seems to qualify for SWAT deployment, as it's a simple config change.

If you aren't too comfortable with that, a possibility is a deployment on commons.wikimedia.beta.wmflabs.org prior to prod.

Someone have a working link to the discussions?

Someone have a working link to the discussions?

It's in the URL field.

Is there still valid consensus for this?

Yeah, February 2009. I'm not sure about it because of that... :/

I think this came up again in January 2015 (per the gerrit patches). I cannot find the commons discussion though (it should have a link to the Phab ticket).

Deskana lowered the priority of this task from Medium to Low.Dec 31 2015, 5:20 AM
Deskana subscribed.
Dereckson renamed this task from Default our search box to "Search" instead of "Go" on Commons to Default action for Commons search box should be "Search" instead of "Go".Apr 4 2016, 12:34 PM

Started a new discussion at https://commons.wikimedia.org/wiki/Commons:Village_pump/Proposals#Default_action_for_the_search_field per Krenair comment about the staleness of 2009.

By the way, Vector offers a "jump to" functionality absent of old Monobook search box. We would lose that if we'd enable this change.

Discussion update: there could be a preference from Commons community to move galeries pages from NS_MAIN to a dedicated namespace. That would solve the issue, and would allow to still use Vector jump to feature.

Change 186916 abandoned by Hashar:
Allow a full text search button on Commons whenever possible

Reason:
Old change / no consensus reached yet on T19471

https://gerrit.wikimedia.org/r/186916

Dereckson closed this task as Declined.EditedNov 8 2016, 3:44 PM

Per https://commons.wikimedia.org/wiki/Commons:Village_pump/Proposals/Archive/2016/04#Default_action_for_the_search_field which suggests another course of action: to move galerie pages to a dedicated namespace.

There is ample consensus of dozens users for the change, though the implementation seems harder than expected; only Dereckson opposed the change of the default in the discussion, while two other users opposed the removal of the "Go" option (which was not proposed).

@Nemo_bis This is the second time you reopen this task, already WONTFIX in 2010 by @JeLuF after Vector delivery.

The 2009 discussion was based on Monobook and gained 15 support. The 2015 discussion based on Vector (where I indeed made an objection) has 4 oppose (so it's not "only Dereckson"), no support.

This discussion led to an emerging consensus to instead exile the galleries from main to another namespace.

The 2009 request could was to switch from a [ GO ] [ SEARCH] to a [ SEARCH ]. The 2015 discussion highlight the fact Vector offers new features to the search box, features making moot the GO/SEARCH question.

I so suggest to:

  • wait the Commons community works on the move proposal
  • revisit this issue afterwards in a larger consultation of the Commons community than 15 or 7 persons
Urbanecm subscribed.

Mass-declining of all old "Blocked on community consensus" site request tasks. If this is still wanted, please make sure community consensus was reached and if so, please re-open this task and link to the discussion.