Author: ioeth.trocolar
Description:
It has been brought to my attention at http://en.wikipedia.org/wiki/Wikipedia:TW/BUG#TW-B-0250 that Twinkle (and WP:FRIENDLY|Friendly as well, of course) are having problems editing pages that are utilizing editnotices. I think I've tracked the problem down to a case of bad XML (HTML) being returned from the server, although I cannot figure out what the cause would be, other than a bug in the MediaWiki software. That being the case, I'm coming here to confirm. I'll be using the talk page of User:Amalthea (http://en.wikipedia.org/wiki/User_talk:Amalthea) to demonstrate what I'm talking about.
First, have a look at http://en.wikipedia.org/wiki/User_talk:Amalthea/Editnotice. Pretty standard, right? And when you do a "View Page Source" have a look at the HTML generated by the {{tmbox}} template, in particular at the end of the unordered list (<ul> tag). Nothing wrong there.
Now, have a look at the same section of HTML when you edit Amalthea's talk page (http://en.wikipedia.org/w/index.php?title=User_talk:Amalthea&action=edit). What I'm seeing is that the </td> tag from the {{tmbox}} template is somehow being placed before the </li></ul> tags that close the unordered list. Immediately following the </li></ul> line is a line with </tr> to close the table row. This is clearly incorrect and is, I believe, causing the XML parser to bomb out when doing Twinkle or Friendly functions to pages where this occurs.
If I just use one line of plain text in an editnotice, the corresponding HTML on the page where it is displayed is correct. However, if I use a bulleted list, the MediaWiki software incorrectly places the </div> tag exactly as it was doing to the </td> tag in the previous example. It seems that there might be a problem specifically with unordered lists in editnotices. Have a look at editing my user talk page (http://en.wikipedia.org/w/index.php?title=User_talk:Ioeth&action=edit) for an example.