Maniphest T194909

Revert bot ignores some pages unexpectedly
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dalba
	May 18 2018, 6:07 AM

Description

If an edit is on a page which its content does not match the regex r\[\[.+?:.+?\..+?\]\], it won't get reverted.

I think this behavior does not make sense or at least should be documented.

Details

	Subject	Repo	Branch	Lines +/-
	scripts/revertbot.py: Remove RevertBot class	pywikibot/core	master	+27 -26

Customize query in gerrit

Related Objects

Mentioned In: T194976: Move BaseRevertBot to specialbots.py
T129526: revertbot uses myRevertBot class by default, which has an odd default page filter
Mentioned Here: T194976: Move BaseRevertBot to specialbots.py

Event Timeline

Dalba created this task.May 18 2018, 6:07 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptMay 18 2018, 6:07 AM

Dalba updated the task description. (Show Details)May 18 2018, 6:08 AM

Dalba updated the task description. (Show Details)

Change 433701 had a related patch set uploaded (by Dalba; owner: Dalba):
[pywikibot/core@master] scripts/revertbot.py: Remove RevertBot class

https://gerrit.wikimedia.org/r/433701

gerritbot added a project: Patch-For-Review.May 18 2018, 9:09 AM

Well it is just an example, as the doc comment says. Probably it should just be moved to the initial doc comment instead of removing. It might be confusing for experienced users, but also helpful for novice users..

In T194909#4213046, @Dvorapa wrote:

Well it is just an example, as the doc comment says. Probably it should just be moved to the initial doc comment instead of removing. It might be confusing for experienced users, but also helpful for novice users..

Yes it was intended to be a sample. It is unusable like the basic.py. Anyway revertbot isn't really a working bot script and wasn't it never. Probably the BaseRevertBot class should be moved to specialbot.py.

Xqt triaged this task as Lowest priority.May 18 2018, 10:20 AM

Xqt closed this task as Resolved.May 18 2018, 12:17 PM

Xqt claimed this task.

Change 433701 merged by jenkins-bot:
[pywikibot/core@master] scripts/revertbot.py: Remove RevertBot class

https://gerrit.wikimedia.org/r/433701

Dalba mentioned this in T129526: revertbot uses myRevertBot class by default, which has an odd default page filter.May 18 2018, 4:37 PM

Dalba claimed this task.May 18 2018, 4:40 PM

Dvorapa merged a task: T129526: revertbot uses myRevertBot class by default, which has an odd default page filter.May 18 2018, 4:43 PM

Dvorapa added a subscriber: valhallasw.

In T194909#4213146, @Xqt wrote:

In T194909#4213046, @Dvorapa wrote:

Well it is just an example, as the doc comment says. Probably it should just be moved to the initial doc comment instead of removing. It might be confusing for experienced users, but also helpful for novice users..

Yes it was intended to be a sample. It is unusable like the basic.py. Anyway revertbot isn't really a working bot script and wasn't it never. Probably the BaseRevertBot class should be moved to specialbot.py.