Page MenuHomePhabricator

[BUG] Empty state illustrations on Reading lists and History moving when search is triggered
Closed, ResolvedPublic

Description

This appears to be a regression, as the empty state illustrations on these two screens are meant to be static.

Steps to reproduce

Pre-conditions: Delete all reading lists and clear history

  1. Open the app to the Reading list tab. Note the position of the empty state illustration.
  2. Tap to Search.
  3. Go to History tab and note the position of the empty state illustration on this screen.
  4. Tap to Search
Expected

For steps 2 and 4, the empty state illustrations should remain fixed in place

Actual

In steps 2 and 4, the empty state illustrations shift out of position.

Open each GIF in full screen to see animation:

History-empty-state-moving-bug.gif (960×540 px, 288 KB)
|
Reading-lists-empty-state-moving-bug.gif (960×540 px, 306 KB)

Occurring on

Wikipedia v2.7.232-alpha-2018-05-15

Possible related: T166151

Event Timeline

Change 434615 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Fix: Empty state illustrations on Reading lists and History

https://gerrit.wikimedia.org/r/434615

@RHo Is this actually the expected behavior? When the keyboard is shown, it has the effect of shrinking the effective screen height that is available for the activity. Therefore the empty graphic is shown in the "center" of the effective screen. If we make the empty graphic hide behind the keyboard (i.e. the keyboard no longer shrinks the screen height), it would also have the effect of making list items inaccessible that are hidden behind the keyboard. (Suppose you're typing a search term and we present many results, they would no longer be scrollable to the top past the height of the keyboard.)

hey @Dbrant -yes, in these two contexts (Reading lists and History is empty) it is expected that the graphics are not re-positioned and centered when the user taps search, since the message is shown fully by default. \
Conversely it makes sense for the empty search graphic is auto-centered because the default state a user entering this screen is with the keyboard open.

Change 434615 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix: Empty state illustrations on Reading lists and History

https://gerrit.wikimedia.org/r/434615

hi @Dbrant - looks like the search graphic is now static as well unexpectedly, as is the 'no results' illustration
Actual:

image.png (1×1 px, 154 KB)
image.png (1×1 px, 152 KB)

Change 438123 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Follow up: Empty state illustrations on Reading lists and History

https://gerrit.wikimedia.org/r/438123

Thanks, @RHo. I made another patch to update the behaviors, will let you know once the patch gets merged.

Change 438123 merged by jenkins-bot:
[apps/android/wikipedia@master] Follow up: Empty state illustrations on Reading lists and History

https://gerrit.wikimedia.org/r/438123

LGTM on Pixel 2 (8.1) using Wikipedia v2-7-234-alpha-2018-06-12.

Moving to QA for testing on a few more devices.

Testing that:

  • Empty state illustrations on History and Reading lists remain in place when search is triggered on either of these views.
  • Empty state illustration on Search (when there are no recent searches) moves to be centered when the keyboard is opened/closed in searching Wikipedia.
  • "No results found" illustration and message also moves to be centered when the keyboard is opened/closed in searching Wikipedia.

The simple uses cases noted above seems to be working fine for me too on a Galaxy j1 ace (5.1.1) using Wikipedia v2-7-234-alpha-2018-06-14. Interestingly the following case doesn't seem to be working as expected, though.

  1. Open the app
  2. Tap on the search bar to search Wikipedia
  3. Tap on the 'MORE' button to view the language list (or the language button if the app is currently made to handle only one language)
  4. Come Back (with/without changing the languages) to the search screen

In the above case both the empty state illustration and the "No results found" illustration are not centered when the keyboard is opened/closed in searching Wikipedia.

Vvjjkkii renamed this task from [BUG] Empty state illustrations on Reading lists and History moving when search is triggered to trcaaaaaaa.Jul 1 2018, 1:09 AM
Vvjjkkii reopened this task as Open.
Vvjjkkii removed cooltey as the assignee of this task.
Vvjjkkii raised the priority of this task from Medium to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii edited subscribers, added: cooltey; removed: gerritbot, Aklapper.
Kaartic renamed this task from trcaaaaaaa to [BUG] Empty state illustrations on Reading lists and History moving when search is triggered.Jul 1 2018, 1:23 PM
Kaartic closed this task as Resolved.
Kaartic assigned this task to cooltey.
Kaartic lowered the priority of this task from High to Medium.
Kaartic updated the task description. (Show Details)
Kaartic edited subscribers, added: Aklapper; removed: cooltey.