Maniphest T194979

Special pages shouldn't use wb-input anymore
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Sjoerddebruin
	May 18 2018, 4:59 PM

Description

The following special pages now use wb-input, causing the submit button flowing right next to the fields. Looking at Special:NewItem and other Wikbase special pages, this doesn't seem standard for them.

Special:SetLabel
Special:SetDescription
Special:SetAliases
Special:SetLabelDescriptionAliases

Special:SetSiteLink also still used wb-input, but this only caused a small margin error under the checkboxes.

Details

	Subject	Repo	Branch	Lines +/-
	Remove redundant Wikibase styles for special pages	mediawiki/extensions/Wikibase	master	+7 -56

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T96040 Wikibase special pages (tracking)
		Resolved		Sjoerddebruin	T194979 Special pages shouldn't use wb-input anymore

Event Timeline

Sjoerddebruin created this task.May 18 2018, 4:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 18 2018, 4:59 PM

• StjnVMF renamed this task from Special pages to edit terms shouldn't use wb-input to unban reguyla.May 18 2018, 5:22 PM

• StjnVMF updated the task description. (Show Details)

Sjoerddebruin renamed this task from unban reguyla to Special pages to edit terms shouldn't use wb-input.May 18 2018, 5:25 PM

Sjoerddebruin updated the task description. (Show Details)

• Huonenwiki merged a task: T27703: Add warning, when upload file in CMYK color model.May 18 2018, 5:38 PM

• Huonenwiki added subscribers: Umherirrender, AbdealiJK, Matanya and 4 others.

• Rfarrand moved this task from Backlog to Project on the Wikimedia-Hackathon-2018 board.May 18 2018, 5:47 PM

JJMC89 removed subscribers: • wikibugs-l-list, Bawolff, • gpaumier and 4 others.May 18 2018, 6:24 PM

Sjoerddebruin added a parent task: T96040: Wikibase special pages (tracking).May 19 2018, 9:22 AM

Change 433957 had a related patch set uploaded (by Sjoerddebruin; owner: Sjoerddebruin):
[mediawiki/extensions/Wikibase@master] Remove .wb-input from term special pages

https://gerrit.wikimedia.org/r/433957

gerritbot added a project: Patch-For-Review.May 19 2018, 11:15 AM

So I've just discovered that this is a leftover from our special pages before the ooui conversion. A part was removed in T159702, but it seems like we don't need these CSS styles (from 2012!) at all anymore. I've updated the patch to remove the CSS file and the usage in the tests. Also Special:SetSiteLink was still using these styles, after this change has been merged the margin under the checkboxes will be okay again.

Sjoerddebruin renamed this task from Special pages to edit terms shouldn't use wb-input to Special pages shouldn't use wb-input anymore.May 19 2018, 12:30 PM

Sjoerddebruin updated the task description. (Show Details)

Sjoerddebruin moved this task from incoming to in progress on the Wikidata board.May 23 2018, 11:37 AM

• Vvjjkkii renamed this task from Special pages shouldn't use wb-input anymore to 8qcaaaaaaa.Jul 1 2018, 1:09 AM

• Vvjjkkii removed Sjoerddebruin as the assignee of this task.

• Vvjjkkii triaged this task as High priority.