Page MenuHomePhabricator
Create Task
Maniphest T195020

AntiSpoof extension does not pass quibble-vendor-mysql-php70-docker
Closed, ResolvedPublic
Actions

Description

The quibble-vendor-mysql-php70-docker from experimental run is failing for AntiSpoof
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php70-docker/3080/console trigged by https://gerrit.wikimedia.org/r/#/c/433891/

There were 2 failures:

1) SpoofUserTest::testGetConflicts with data set #1 ('FooBaz', array('F00BAZ', 'FOOBAZ', 'FooBaz'))
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => 'F00BAZ'
     1 => 'FOOBAZ'
-    2 => 'FooBaz'

/workspace/src/tests/phpunit/MediaWikiTestCase.php:1790
/workspace/src/extensions/AntiSpoof/tests/phpunit/SpoofUserTest.php:56
/workspace/src/tests/phpunit/MediaWikiTestCase.php:423
/workspace/src/maintenance/doMaintenance.php:94

2) SpoofUserTest::testUpdate
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => 'BazF00'
-    1 => 'BazFoo'

/workspace/src/tests/phpunit/MediaWikiTestCase.php:1790
/workspace/src/extensions/AntiSpoof/tests/phpunit/SpoofUserTest.php:79
/workspace/src/tests/phpunit/MediaWikiTestCase.php:423
/workspace/src/maintenance/doMaintenance.php:94

FAILURES!
Tests: 1295, Assertions: 22893, Failures: 2.

The failing test is a php7.0 test, so adding the tag for it

Details

SubjectRepoBranchLines +/-
Use binary collation in mysql for varcharsmediawiki/extensions/AntiSpoofmaster+25 -2
Migrate to Quibble extensions blocked by AntiSpoofintegration/configmaster+6 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.May 18 2018, 9:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 18 2018, 9:22 PM
Umherirrender edited projects, added Continuous-Integration-Infrastructure; removed PHP 7.0 support.May 19 2018, 9:40 AM

This depends on the locale your database is using, because in the test results only entries are missing which also exists in upper case and camel case inside the test (see the list in $usernames)

I can fix this by using binary varchar in the extension. I am not sure, if that is the best solution just to fix tests.
Or does this test now catch a problem for wikis using non-binary locales?

gerritbot subscribed.May 19 2018, 10:20 AM

Change 433950 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/AntiSpoof@master] Rework database design

https://gerrit.wikimedia.org/r/433950

gerritbot added a project: Patch-For-Review.May 19 2018, 10:20 AM
Umherirrender merged a task: T194774: PHPUnit is failing with no reason for TorBlock.May 19 2018, 10:27 AM
Umherirrender added subscribers: Daimona, MarcoAurelio.
MarcoAurelio added a comment.May 21 2018, 4:02 PM

Is this Schema-change / Schema-change-in-production ? I've added @Marostegui on the patch nonetheless. Thanks.

Umherirrender added a comment.May 21 2018, 5:54 PM
In T195020#4220998, @MarcoAurelio wrote:

Is this Schema-change / Schema-change-in-production ? I've added @Marostegui on the patch nonetheless. Thanks.

I would see T193532 as the schema change bug. The Schema-change-in-production is needed when the schema change must be run in production and is created after the merge of the Schema-change bug (thats my understanding).

hashar added a parent task: T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.May 25 2018, 12:26 PM
hashar added a comment.EditedMay 25 2018, 12:42 PM

The quibble* jobs runs with MariaDB with the collation latin1_swedish_ci. Maybe that ci stands for case insensitive? The Nodepool jobs use MySQL with apparently the same collation.

hashar mentioned this in T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.May 25 2018, 1:08 PM
hashar added a comment.Jun 13 2018, 1:53 PM

MariaDB has been changed in the Quibble containers to use binary. 7d740b5167e1625c690d6f59b6b0e0ac35c4694d T193222

--- a/dockerfiles/quibble-stretch/mariadb.cnf
+++ b/dockerfiles/quibble-stretch/mariadb.cnf
 [mysqld]
+character_set_server     = binary
+character_set_filesystem = binary
+collation_server         = binary
hashar added a comment.EditedJun 13 2018, 1:54 PM

I have triggered the Quibble jobs against the dummy change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AntiSpoof/+/54376

And it passed just fine!

So for the CI migration it is fixed, it is probably still worth doing the database schema change though.

Daimona mentioned this in T193529: [AbuseFilter] AbuseFilter/abusefilter.tables.sql : Error: 1071 Specified key was too long; max key length is 767 bytes.Jun 13 2018, 2:48 PM
gerritbot added a comment.Jun 14 2018, 9:34 AM

Change 440298 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Migrate to Quibble extensions blocked by AntiSpoof

https://gerrit.wikimedia.org/r/440298

hashar added a comment.Jun 14 2018, 9:37 AM

@Umherirrender seems like using binary has a database character set fix the test. Thus I am not sure whether the database is still needed, but then I havent looked at your change.

hashar removed a project: Continuous-Integration-Infrastructure.Jun 14 2018, 9:37 AM
gerritbot added a comment.Jun 14 2018, 9:38 AM

Change 440298 merged by jenkins-bot:
[integration/config@master] Migrate to Quibble extensions blocked by AntiSpoof

https://gerrit.wikimedia.org/r/440298

gerritbot added a comment.Jun 19 2018, 5:54 PM

Change 433950 abandoned by Umherirrender:
Use binary collation in mysql for varchars

Reason:
Tests now passed by using binary as default collation

https://gerrit.wikimedia.org/r/433950

Umherirrender closed this task as Resolved.Jun 19 2018, 5:55 PM
Umherirrender triaged this task as Medium priority.
• Vvjjkkii renamed this task from AntiSpoof extension does not pass quibble-vendor-mysql-php70-docker to 3pcaaaaaaa.Jul 1 2018, 1:10 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: MarcoAurelio, gerritbot, Aklapper.
Daimona merged a task: T194774: PHPUnit is failing with no reason for TorBlock.Jul 1 2018, 12:42 PM
Daimona added subscribers: Aklapper, MarcoAurelio.
CommunityTechBot renamed this task from 3pcaaaaaaa to AntiSpoof extension does not pass quibble-vendor-mysql-php70-docker.Jul 1 2018, 8:38 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot claimed this task.
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: gerritbot.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL