Page MenuHomePhabricator

Travis is failing since "[cleanup] Deprecate pagegenerators.UnconnectedPageGenerator"
Closed, ResolvedPublic

Description

{35493514edf43529a3db2186154e083aedc335d1}

Event Timeline

Cannot read the travis log due to the explorer is always failing. Can you tag the error exception here please.

Xqt triaged this task as High priority.May 19 2018, 11:04 AM

For me too, but raw log option is a great workaround:

en:wikipedia py3.6
=================================== FAILURES ===================================
___________ TestUnconnectedPageGenerator.test_unconnected_with_repo ____________

self = <tests.pagegenerators_tests.TestUnconnectedPageGenerator testMethod=test_unconnected_with_repo>

    def test_unconnected_with_repo(self):
        """Test UnconnectedPageGenerator."""
        if not self.site.data_repository():
            raise unittest.SkipTest('Site is not using a Wikibase repository')
        upgen = pagegenerators.UnconnectedPageGenerator(self.site, 3)
    
        def unconnected_pages(total=None):
            """Assert unconnected_pages is called correctly."""
            self.assertEqual(total, 3)
            yield
    
        with patch.object(self.site, 'unconnected_pages', unconnected_pages):
>           self.assertEqual(tuple(upgen), (None,))
E           AssertionError: Tuples differ: (Page('Irukkam Island'), Page('Robert Troyer'), Page('Tommy Wheeldon Jr.')) != (None,)
E           
E           First differing element 0:
E           Page('Irukkam Island')
E           None
E           
E           First tuple contains 2 additional elements.
E           First extra element 1:
E           Page('Robert Troyer')
E           
E           - (Page('Irukkam Island'), Page('Robert Troyer'), Page('Tommy Wheeldon Jr.'))
E           + (None,)

tests/pagegenerators_tests.py:1495: AssertionError
------------------------------ Captured log call -------------------------------
connectionpool.py          396 DEBUG    https://en.wikipedia.org:443 "GET /w/api.php?gqppage=UnconnectedPages&prop=info%7Cimageinfo%7Ccategoryinfo&inprop=protection&iiprop=timestamp%7Cuser%7Ccomment%7Curl%7Csize%7Csha1%7Cmetadata&generator=querypage&action=query&indexpageids=&continue=&gqplimit=3&meta=userinfo&uiprop=blockinfo%7Chasmsg&maxlag=5&format=json HTTP/1.1" 200 None
=============================== warnings summary ===============================

Change 433962 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Don't patch the site.unconnected_pages

https://gerrit.wikimedia.org/r/433962

Change 433962 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Don't patch the site.unconnected_pages

https://gerrit.wikimedia.org/r/433962

Vvjjkkii renamed this task from Travis is failing since "[cleanup] Deprecate pagegenerators.UnconnectedPageGenerator" to fpcaaaaaaa.Jul 1 2018, 1:09 AM
Vvjjkkii reopened this task as Open.
Vvjjkkii removed Xqt as the assignee of this task.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from fpcaaaaaaa to Travis is failing since "[cleanup] Deprecate pagegenerators.UnconnectedPageGenerator".Jul 2 2018, 1:43 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Xqt.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added subscribers: gerritbot, Aklapper.