Page MenuHomePhabricator

Make Celery `result_backend` and `broker_url` configurable by environment variable
Closed, DeclinedPublic

Description

This will make it easy to pass the redis service URL into new containers.

Celery already comes with a config_from_envvar function, which is called explicitly for each variable we want to allow to be overridden from the environment, but ORES reuses this configuration itself, so we should probably pull the data out of the Celery app object after configuring it.

Event Timeline

Vvjjkkii renamed this task from Make Celery `result_backend` and `broker_url` configurable by environment variable to locaaaaaaa.Jul 1 2018, 1:09 AM
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from locaaaaaaa to Make Celery `result_backend` and `broker_url` configurable by environment variable.Jul 1 2018, 6:16 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added a subscriber: Aklapper.
Ladsgroup subscribed.

This is not needed as we have docker tests coming from a dedicated yaml file. Right? Reopen if that's not the case.

The details are vague to me at this point, but I think the issue was that we would be spinning up several docker containers and they have to be able to find each other. If we're getting the URLs configured some other way, that's fine!