Page MenuHomePhabricator
Create Task
Maniphest T195111

Avoid jQuery & CE code in ve.dm.
Closed, ResolvedPublic
Actions

Description

In theory it should be possible to run the VE data model on a server with a virtual DOM, but no jQuery.

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.May 19 2018, 7:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 19 2018, 7:08 PM
gerritbot subscribed.May 19 2018, 7:11 PM

Change 434053 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] $.isEmptyObject -> ve.isEmptyObject

https://gerrit.wikimedia.org/r/434053

gerritbot added a project: Patch-For-Review.May 19 2018, 7:11 PM
gerritbot added a comment.May 19 2018, 7:45 PM

Change 434056 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Don't use $.isNumeric in DM

https://gerrit.wikimedia.org/r/434056

gerritbot added a comment.May 19 2018, 7:45 PM

Change 434057 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Avoid more jQuery in DM

https://gerrit.wikimedia.org/r/434057

gerritbot added a comment.May 19 2018, 8:23 PM

Change 434053 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] $.isEmptyObject -> ve.isEmptyObject

https://gerrit.wikimedia.org/r/434053

gerritbot added a comment.May 19 2018, 8:25 PM

Change 434056 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Don't use $.isNumeric in DM

https://gerrit.wikimedia.org/r/434056

gerritbot added a comment.May 19 2018, 8:26 PM

Change 434057 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Avoid more jQuery in DM

https://gerrit.wikimedia.org/r/434057

Jdforrester-WMF subscribed.May 20 2018, 7:45 AM

Remaining uses are $.Deferred, $.parseHTML, $.getJSON, $.when, and $.noop.

Jdforrester-WMF assigned this task to Esanders.May 20 2018, 7:45 AM
Jdforrester-WMF edited projects, added VisualEditor (Current work), VisualEditor-DataModel; removed Patch-For-Review, VisualEditor.
Jdforrester-WMF moved this task from Incoming to In progress on the VisualEditor (Current work) board.
Esanders added a comment.May 23 2018, 11:03 AM

I've deleted APIResults* in https://gerrit.wikimedia.org/r/#/c/434659/ (they were downstreamed to MW a while ago).

That leaves:

  • $.parseHTML in the DOMPurify code in ve.dm.Change. As that code only exists to protect clients, we could safely skip it on a server instance.
  • Deferred/promise code in surface fragments. We'll need to make sure our promise usage is compatible with other promise libraries so we can abstract this to ve.Deferred / ve.when etc.
Esanders updated the task description. (Show Details)May 23 2018, 11:04 AM

I also recently put in some hacks to call out to the CE node in #toDomElements, these may need to be refactored.

• Deskana triaged this task as Medium priority.May 23 2018, 11:29 AM
gerritbot added a comment.May 23 2018, 4:01 PM

Change 434661 had a related patch set uploaded (by Jforrester; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d214a66aa)

https://gerrit.wikimedia.org/r/434661

gerritbot added a project: Patch-For-Review.May 23 2018, 4:01 PM
gerritbot added a comment.May 23 2018, 4:39 PM

Change 434661 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d214a66aa)

https://gerrit.wikimedia.org/r/434661

Jdforrester-WMF removed a project: Patch-For-Review.May 23 2018, 4:41 PM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).May 23 2018, 5:00 PM
• Vvjjkkii renamed this task from Avoid jQuery in ve.dm. to kncaaaaaaa.Jul 1 2018, 1:09 AM
• Vvjjkkii removed Esanders as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from kncaaaaaaa to Avoid jQuery in ve.dm..Jul 1 2018, 10:32 PM
CommunityTechBot assigned this task to Esanders.
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
Esanders edited projects, added VisualEditor; removed VisualEditor (Current work).Aug 9 2018, 4:52 PM
Esanders added a comment.Aug 21 2018, 2:01 PM

As of T178780 we have a reference to ve.ce.TextNode in ve.dm.Converter. This could probably be moved into a utility namespace

Esanders renamed this task from Avoid jQuery in ve.dm. to Avoid jQuery & CE code in ve.dm..Aug 21 2018, 2:01 PM
Esanders removed Esanders as the assignee of this task.
gerritbot added a comment.Sep 22 2018, 8:29 PM

Change 462164 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Move whitespaceHtmlCharacters to ve.utils.js

https://gerrit.wikimedia.org/r/462164

gerritbot added a project: Patch-For-Review.Sep 22 2018, 8:29 PM
gerritbot added a comment.Sep 23 2018, 7:00 PM

Change 462164 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Move whitespaceHtmlCharacters to ve.utils.js and rename

https://gerrit.wikimedia.org/r/462164

gerritbot added a comment.Sep 23 2018, 8:53 PM

Change 462321 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7c9ceb939)

https://gerrit.wikimedia.org/r/462321

gerritbot added a comment.Sep 23 2018, 9:43 PM

Change 462321 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7c9ceb939)

https://gerrit.wikimedia.org/r/462321

Jdforrester-WMF closed this task as Resolved.Sep 24 2018, 3:05 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)); removed Patch-For-Review, MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 24 2018, 3:05 PM
gerritbot added a comment.Sep 27 2018, 11:42 AM

Change 463235 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Avoid jQuery in ve.dm.Model.static.describeChange(s)

https://gerrit.wikimedia.org/r/463235

gerritbot added a project: Patch-For-Review.Sep 27 2018, 11:43 AM
gerritbot added a comment.Sep 27 2018, 3:58 PM

Change 463235 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Avoid jQuery in ve.dm.Model.static.describeChange(s)

https://gerrit.wikimedia.org/r/463235

gerritbot added a comment.Sep 27 2018, 5:05 PM

Change 463299 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[VisualEditor/VisualEditor@master] eslint: Disable jquery environment expectation in DM code

https://gerrit.wikimedia.org/r/463299

Jdforrester-WMF reopened this task as Open.Sep 27 2018, 5:05 PM
Jdforrester-WMF moved this task from To Triage to Planned Maintenance on the VisualEditor board.
gerritbot added a comment.Sep 27 2018, 7:25 PM

Change 463355 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (5742a48a3)

https://gerrit.wikimedia.org/r/463355

gerritbot added a comment.Sep 27 2018, 7:51 PM

Change 463355 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (5742a48a3)

https://gerrit.wikimedia.org/r/463355

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)); removed MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)).Sep 27 2018, 8:00 PM
gerritbot added a comment.Nov 5 2018, 3:43 PM

Change 463299 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] eslint: Disable jQuery/browser environment expectation in DM code

https://gerrit.wikimedia.org/r/463299

gerritbot added a comment.Nov 6 2018, 3:34 PM

Change 471985 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Abstract construction of Deferred objects and $.when

https://gerrit.wikimedia.org/r/471985

gerritbot added a comment.Nov 7 2018, 4:11 PM

Change 463299 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] eslint: Disable jQuery/browser environment expectation in DM code

https://gerrit.wikimedia.org/r/463299

gerritbot added a comment.Nov 7 2018, 6:20 PM

Change 471985 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Abstract construction of Deferred objects and $.when

https://gerrit.wikimedia.org/r/471985

gerritbot added a comment.Nov 8 2018, 11:45 AM

Change 472417 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (0d1902e04)

https://gerrit.wikimedia.org/r/472417

gerritbot added a comment.Nov 8 2018, 12:07 PM

Change 472417 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (0d1902e04)

https://gerrit.wikimedia.org/r/472417

JTannerWMF moved this task from Planned Maintenance to FY 19-20 on the VisualEditor board.Dec 12 2018, 2:53 PM
Aklapper removed a project: Patch-For-Review.Oct 15 2020, 1:11 PM

@Esanders: All related patches in Gerrit have been merged. Can this task be resolved (via Add Action... → Change Status in the dropdown menu), or is there more to do in this task? Asking as you are set as task assignee. Thanks in advance!

Jdforrester-WMF closed this task as Resolved.Oct 15 2020, 5:28 PM

Yeah, this is now programmatically enforced.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits