Maniphest T195130

BlueSpiceFoundation extension is missing @covers tags
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	May 20 2018, 1:52 AM

Description

PHPCS has identified that some of the BlueSpiceFoundation PHPUnit tests are missing @covers tags. Those tags
are necessary for PHPUnit to accurately calculate test coverage.

See the PHPUnit documentation for how to use it.

Once the tags have been added, the MissingCovers sniff should be re-enabled in .phpcs.xml.

Details

Subject	Repo	Branch	Lines +/-
Fix missing test covers for phpcs	mediawiki/extensions/BlueSpiceFoundation	REL1_31	+186 -14
Fix missing test covers for phpcs	mediawiki/extensions/BlueSpiceFoundation	REL1_31_dev	+186 -14
Fix missing test covers for phpcs	mediawiki/extensions/BlueSpiceFoundation	master	+192 -8

Customize query in gerrit

Event Timeline

Legoktm added projects: MediaWiki-extensions-Other, Test-Coverage.May 20 2018, 1:52 AM

Legoktm subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2018, 1:52 AM

Legoktm edited projects, added BlueSpice; removed MediaWiki-extensions-Other.May 20 2018, 1:58 AM

• Vvjjkkii renamed this task from BlueSpiceFoundation extension is missing @covers tags to 1mcaaaaaaa.Jul 1 2018, 1:08 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from 1mcaaaaaaa to BlueSpiceFoundation extension is missing @covers tags.Jul 1 2018, 5:28 PM

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

Change 564918 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceFoundation@master] Fix missing test covers for phpcs

https://gerrit.wikimedia.org/r/564918

Pwirth closed this task as Resolved.Jan 17 2020, 7:32 AM

Pwirth claimed this task.

Change 565503 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpiceFoundation@REL1_31_dev] Fix missing test covers for phpcs

https://gerrit.wikimedia.org/r/565503

Change 565504 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpiceFoundation@REL1_31] Fix missing test covers for phpcs

https://gerrit.wikimedia.org/r/565504

Change 565503 merged by Robert Vogel:
[mediawiki/extensions/BlueSpiceFoundation@REL1_31_dev] Fix missing test covers for phpcs