Page MenuHomePhabricator
Create Task
Maniphest T195139

Flow extension is missing @covers tags
Closed, ResolvedPublic
Actions

Description

PHPCS has identified that some of the Flow PHPUnit tests are missing @covers tags. Those tags
are necessary for PHPUnit to accurately calculate test coverage.

See the PHPUnit documentation for how to use it.

Once the tags have been added, the MissingCovers sniff should be re-enabled in .phpcs.xml.

Details

SubjectRepoBranchLines +/-
Add more @covers tags in not so obvious casesmediawiki/extensions/Flowmaster+6 -0
Add missing @covers tags to test classes in all trivial casesmediawiki/extensions/Flowmaster+110 -2
Add @covers tags to Flow's PHPUnit testsmediawiki/extensions/Flowmaster+2 -0
Customize query in gerrit

Event Timeline

Legoktm added projects: MediaWiki-extensions-Other, Test-Coverage.May 20 2018, 1:53 AM
Legoktm subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2018, 1:53 AM
Legoktm edited projects, added StructuredDiscussions; removed MediaWiki-extensions-Other.May 20 2018, 1:59 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMay 20 2018, 1:59 AM
gerritbot subscribed.May 29 2018, 9:02 PM

Change 435779 had a related patch set uploaded (by Catrope; owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Flow@master] Add @covers tags to Flow's PHPUnit tests

https://gerrit.wikimedia.org/r/435779

gerritbot added a project: Patch-For-Review.May 29 2018, 9:02 PM
gerritbot added a comment.May 29 2018, 9:14 PM

Change 435779 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Add @covers tags to Flow's PHPUnit tests

https://gerrit.wikimedia.org/r/435779

gerritbot added a comment.May 30 2018, 12:43 PM

Change 436273 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Flow@master] Add missing @covers tags to test classes in all trivial cases

https://gerrit.wikimedia.org/r/436273

gerritbot added a comment.May 30 2018, 12:43 PM

Change 436275 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Flow@master] Add more @covers tags in not so obvious cases

https://gerrit.wikimedia.org/r/436275

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).May 30 2018, 5:01 PM
gerritbot added a comment.May 30 2018, 5:53 PM

Change 436273 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Add missing @covers tags to test classes in all trivial cases

https://gerrit.wikimedia.org/r/436273

JTannerWMF edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.May 30 2018, 6:18 PM
JTannerWMF moved this task from Untriaged to Snack Box on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
gerritbot added a comment.Jun 3 2018, 2:13 PM

Change 436275 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Add more @covers tags in not so obvious cases

https://gerrit.wikimedia.org/r/436275

• Vvjjkkii renamed this task from Flow extension is missing @covers tags to smcaaaaaaa.Jul 1 2018, 1:08 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from smcaaaaaaa to Flow extension is missing @covers tags.Jul 1 2018, 5:21 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
Legoktm closed this task as Resolved.Aug 25 2018, 6:27 AM
Legoktm assigned this task to thiemowmde.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Flow/+/437186

Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 25 2018, 6:27 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL