Page MenuHomePhabricator
Create Task
Maniphest T195141

JsonConfig extension is missing @covers tags
Closed, ResolvedPublic
Actions

Description

PHPCS has identified that some of the JsonConfig PHPUnit tests are missing @covers tags. Those tags
are necessary for PHPUnit to accurately calculate test coverage.

See the PHPUnit documentation for how to use it.

Once the tags have been added, the MissingCovers sniff should be re-enabled in .phpcs.xml.

Details

SubjectRepoBranchLines +/-
Add missing @covers tags and minor cleanupmediawiki/extensions/JsonConfigmaster+28 -14
Customize query in gerrit

Event Timeline

Legoktm added projects: JsonConfig, Test-Coverage.May 20 2018, 1:53 AM
Legoktm subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2018, 1:53 AM
• Vvjjkkii renamed this task from JsonConfig extension is missing @covers tags to qmcaaaaaaa.Jul 1 2018, 1:08 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from qmcaaaaaaa to JsonConfig extension is missing @covers tags.Jul 1 2018, 5:18 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
gerritbot subscribed.Jul 28 2018, 3:17 AM

Change 448844 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/JsonConfig@master] Add missing @covers tags and minor cleanup

https://gerrit.wikimedia.org/r/448844

gerritbot added a project: Patch-For-Review.Jul 28 2018, 3:17 AM
Umherirrender subscribed.Aug 11 2018, 12:37 PM

Not full done yet, because the patch set contains @covers in JCTabularContentTest.php [1], but it seems that the @covers triggers autoload of \JsonConfig\JCLuaLibrary but Scribunto_LuaLibraryBase is not present and phpunit fails.

It could be possible that the MediaWikiCoversValidator autoload the class to check if the method exists. It could be fixed by adding Scribunto to extension-gate, but that may fail locally for other devoloper. No further idea...

[1] https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/JsonConfig/+/448844/4/tests/phpunit/JCTabularContentTest.php

gerritbot added a comment.Aug 13 2018, 8:14 PM

Change 448844 merged by jenkins-bot:
[mediawiki/extensions/JsonConfig@master] Add missing @covers tags and minor cleanup

https://gerrit.wikimedia.org/r/448844

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 13 2018, 9:00 PM
Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.32-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)).Aug 14 2018, 8:53 PM
Legoktm closed this task as Resolved.Aug 25 2018, 6:25 AM
Legoktm claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL