Page MenuHomePhabricator
Create Task
Maniphest T195142

JsonData extension is missing @covers tags
Closed, ResolvedPublic
Actions

Description

PHPCS has identified that some of the JsonData PHPUnit tests are missing @covers tags. Those tags
are necessary for PHPUnit to accurately calculate test coverage.

See the PHPUnit documentation for how to use it.

Once the tags have been added, the MissingCovers sniff should be re-enabled in .phpcs.xml.

If you are not already familiar with PHPUnit tests and would like to learn more about this: https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Writing_unit_tests has links to some good material on the basics of testing.

Mentors: @Legoktm

Details

SubjectRepoBranchLines +/-
Update @covers tags and reenable rule for phpcsmediawiki/extensions/JsonDatamaster+5 -1
Add missing @covers tags in testsmediawiki/extensions/JsonDatamaster+41 -1
Customize query in gerrit

Event Timeline

Legoktm added projects: MediaWiki-extensions-Other, Test-Coverage.May 20 2018, 1:53 AM
Legoktm subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2018, 1:53 AM
• Vvjjkkii renamed this task from JsonData extension is missing @covers tags to pmcaaaaaaa.Jul 1 2018, 1:08 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
JJMC89 renamed this task from pmcaaaaaaa to JsonData extension is missing @covers tags.Jul 1 2018, 2:27 AM
JJMC89 raised the priority of this task from High to Needs Triage.
JJMC89 removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
JJMC89 updated the task description. (Show Details)
JJMC89 added a subscriber: Aklapper.
Legoktm added a project: Google-Code-in-2018.Sep 12 2018, 5:12 AM
Legoktm updated the task description. (Show Details)
Aklapper updated the task description. (Show Details)Oct 7 2018, 1:03 AM
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2018 board.Oct 7 2018, 1:07 AM

https://codein.withgoogle.com/tasks/6247329951645696/

Kizule claimed this task.Nov 3 2018, 6:05 PM
Restricted Application added a project: User-Kizule. · View Herald TranscriptNov 3 2018, 6:05 PM
gerritbot subscribed.Nov 3 2018, 6:08 PM

Change 471520 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/JsonData@master] Add missing @covers tags in tests

https://gerrit.wikimedia.org/r/471520

gerritbot added a project: Patch-For-Review.Nov 3 2018, 6:08 PM
gerritbot added a comment.Nov 4 2018, 5:45 PM

Change 471520 abandoned by Zoranzoki21:
Add missing @covers tags in tests

https://gerrit.wikimedia.org/r/471520

Kizule removed Kizule as the assignee of this task.Nov 4 2018, 5:45 PM
Kizule removed projects: Patch-For-Review, User-Kizule.
Kizule edited subscribers, added: Kizule; removed: gerritbot.
Kizule unsubscribed.
Arcayn claimed this task.Nov 4 2018, 6:31 PM
gerritbot added a comment.Nov 4 2018, 8:53 PM

Change 471563 had a related patch set uploaded (by Arcayn; owner: Arcayn):
[mediawiki/extensions/JsonData@master] Update @covers tags and reenable rule for phpcs

https://gerrit.wikimedia.org/r/471563

gerritbot added a project: Patch-For-Review.Nov 4 2018, 8:53 PM
Legoktm closed this task as Resolved.Nov 6 2018, 12:07 AM
gerritbot added a comment.Nov 6 2018, 12:40 AM

Change 471563 merged by jenkins-bot:
[mediawiki/extensions/JsonData@master] Update @covers tags and reenable rule for phpcs

https://gerrit.wikimedia.org/r/471563

Peachey88 edited projects, added MediaWiki-extensions-JsonData; removed Patch-For-Review, MediaWiki-extensions-Other.Jan 16 2020, 10:55 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL