Page MenuHomePhabricator

Kartographer extension is missing @covers tags
Closed, ResolvedPublic

Description

PHPCS has identified that some of the Kartographer PHPUnit tests are missing @covers tags. Those tags
are necessary for PHPUnit to accurately calculate test coverage.

See the PHPUnit documentation for how to use it.

Once the tags have been added, the MissingCovers sniff should be re-enabled in .phpcs.xml.

Event Timeline

Vvjjkkii renamed this task from Kartographer extension is missing @covers tags to omcaaaaaaa.Jul 1 2018, 1:08 AM
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
JJMC89 renamed this task from omcaaaaaaa to Kartographer extension is missing @covers tags.Jul 1 2018, 2:21 AM
JJMC89 raised the priority of this task from High to Needs Triage.
JJMC89 updated the task description. (Show Details)
JJMC89 added a subscriber: Aklapper.

Change 455115 had a related patch set uploaded (by Legoktm; owner: Umherirrender):
[mediawiki/extensions/Kartographer@master] Add @covers to unit test

https://gerrit.wikimedia.org/r/455115

Change 455115 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Add @covers to unit test

https://gerrit.wikimedia.org/r/455115

Legoktm assigned this task to Umherirrender.