Maniphest T195147

MultiMaps extension is missing @covers tags
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Legoktm
	May 20 2018, 1:53 AM

Tags

Referenced Files

None

Subscribers

Description

PHPCS has identified that some of the MultiMaps PHPUnit tests are missing @covers tags. Those tags
are necessary for PHPUnit to accurately calculate test coverage.

See the PHPUnit documentation for how to use it.

Once the tags have been added, the MissingCovers sniff should be re-enabled in .phpcs.xml.

If you are not already familiar with PHPUnit tests and would like to learn more about this: https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Writing_unit_tests has links to some good material on the basics of testing.

Mentors: @Legoktm

Details

	Subject	Repo	Branch	Lines +/-
	Add missing @covers tags to test cases	mediawiki/extensions/MultiMaps	master	+130 -2

Customize query in gerrit

Related Objects

Mentioned In: rEMMA1bfb48deae85: Add missing @covers tags to test cases

Event Timeline

Legoktm added projects: MediaWiki-extensions-Other, Test-Coverage.May 20 2018, 1:53 AM

Legoktm subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2018, 1:53 AM

Liuxinyu970226 added a subscriber: Pastakhov.May 20 2018, 10:14 AM

• Vvjjkkii renamed this task from MultiMaps extension is missing @covers tags to kmcaaaaaaa.Jul 1 2018, 1:08 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from kmcaaaaaaa to MultiMaps extension is missing @covers tags.Jul 1 2018, 5:16 PM

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

Legoktm added a project: Google-Code-in-2018.Sep 12 2018, 5:11 AM

Legoktm updated the task description. (Show Details)

Aklapper updated the task description. (Show Details)Oct 7 2018, 1:03 AM

https://codein.withgoogle.com/tasks/5145843779764224/

Kizule added a project: Google-Code-in-2019.Dec 5 2019, 5:11 PM

Aklapper moved this task from Proposed tasks to Missing mentors on the Google-Code-in-2019 board.Dec 5 2019, 5:20 PM

Peachey88 edited projects, added MediaWiki-extensions-MultiMaps; removed MediaWiki-extensions-Other.Jan 12 2020, 7:36 AM

Reedy removed projects: Google-Code-in-2019, Google-Code-in-2018.Nov 10 2020, 2:18 PM

Change 852833 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/MultiMaps@master] Add missing @covers tags to test cases

https://gerrit.wikimedia.org/r/852833

gerritbot added a project: Patch-For-Review.Nov 3 2022, 1:01 PM

Change 852833 merged by Fomafix:

[mediawiki/extensions/MultiMaps@master] Add missing @covers tags to test cases

https://gerrit.wikimedia.org/r/852833

Maintenance_bot removed a project: Patch-For-Review.Nov 4 2022, 4:30 PM

thiemowmde mentioned this in rEMMA1bfb48deae85: Add missing @covers tags to test cases.Nov 4 2022, 7:39 PM