Page MenuHomePhabricator
Create Task
Maniphest T195151

OAuthAuthentication extension is missing @covers tags
Closed, ResolvedPublic
Actions

Description

PHPCS has identified that some of the OAuthAuthentication PHPUnit tests are missing @covers tags. Those tags
are necessary for PHPUnit to accurately calculate test coverage.

See the PHPUnit documentation for how to use it.

Once the tags have been added, the MissingCovers sniff should be re-enabled in .phpcs.xml.

If you are not already familiar with PHPUnit tests and would like to learn more about this: https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Writing_unit_tests has links to some good material on the basics of testing.

Mentors: @Legoktm

Details

SubjectRepoBranchLines +/-
Add missing @covers tagsmediawiki/extensions/OAuthAuthenticationmaster+25 -2
Customize query in gerrit

Event Timeline

Legoktm added projects: MediaWiki-extensions-OAuthAuthentication, Test-Coverage.May 20 2018, 1:53 AM
Legoktm subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2018, 1:53 AM
• Vvjjkkii renamed this task from OAuthAuthentication extension is missing @covers tags to gmcaaaaaaa.Jul 1 2018, 1:09 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from gmcaaaaaaa to OAuthAuthentication extension is missing @covers tags.Jul 1 2018, 5:12 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
Legoktm added a project: Google-Code-in-2018.Sep 12 2018, 5:11 AM
Legoktm updated the task description. (Show Details)
Aklapper updated the task description. (Show Details)Oct 7 2018, 1:03 AM
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2018 board.

https://codein.withgoogle.com/tasks/5788407981670400/

Kizule claimed this task.Nov 11 2018, 2:52 AM
Restricted Application added a project: User-Kizule. · View Herald TranscriptNov 11 2018, 2:52 AM
gerritbot subscribed.Nov 11 2018, 2:53 AM

Change 472865 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/OAuthAuthentication@master] Add missing @covers tags

https://gerrit.wikimedia.org/r/472865

gerritbot added a project: Patch-For-Review.Nov 11 2018, 2:53 AM
zhuyifei1999 subscribed.Dec 5 2018, 12:00 AM
Kizule moved this task from Inbox to Working on on the User-Kizule board.Dec 9 2018, 7:53 AM
Kizule moved this task from Working on to To deploy on the User-Kizule board.Dec 31 2018, 4:35 AM
gerritbot added a comment.Jan 14 2019, 5:40 PM

Change 472865 merged by Umherirrender:
[mediawiki/extensions/OAuthAuthentication@master] Add missing @covers tags

https://gerrit.wikimedia.org/r/472865

Kizule closed this task as Resolved.Jan 20 2019, 2:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL