Page MenuHomePhabricator
Create Task
Maniphest T195152

PageViewInfo extension is missing @covers tags
Closed, ResolvedPublic
Actions

Description

PHPCS has identified that some of the PageViewInfo PHPUnit tests are missing @covers tags. Those tags
are necessary for PHPUnit to accurately calculate test coverage.

See the PHPUnit documentation for how to use it.

Once the tags have been added, the MissingCovers sniff should be re-enabled in .phpcs.xml.

Details

SubjectRepoBranchLines +/-
Add some @coversNothing tagsmediawiki/extensions/PageViewInfomaster+6 -1
Customize query in gerrit

Related Objects

Event Timeline

Legoktm added projects: PageViewInfo, Test-Coverage.May 20 2018, 1:53 AM
Legoktm subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2018, 1:53 AM
• Vvjjkkii renamed this task from PageViewInfo extension is missing @covers tags to fmcaaaaaaa.Jul 1 2018, 1:08 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from fmcaaaaaaa to PageViewInfo extension is missing @covers tags.Jul 1 2018, 5:12 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
gerritbot subscribed.Jul 28 2018, 3:02 AM

Change 448840 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/PageViewInfo@master] Add some @coversNothing tags

https://gerrit.wikimedia.org/r/448840

gerritbot added a project: Patch-For-Review.Jul 28 2018, 3:02 AM
Legoktm mentioned this in rEPI81576cea0a77: Add some @coversNothing tags.Jul 28 2018, 3:05 AM
gerritbot added a comment.Jul 28 2018, 5:23 PM

Change 448840 merged by jenkins-bot:
[mediawiki/extensions/PageViewInfo@master] Add some @coversNothing tags

https://gerrit.wikimedia.org/r/448840

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)).Jul 28 2018, 6:00 PM
Legoktm closed this task as Resolved.Jul 29 2018, 11:34 PM
Legoktm claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL