Maniphest T195159

ReadingLists extension is missing @covers tags
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	May 20 2018, 1:53 AM

Description

PHPCS has identified that some of the ReadingLists PHPUnit tests are missing @covers tags. Those tags
are necessary for PHPUnit to accurately calculate test coverage.

See the PHPUnit documentation for how to use it.

Once the tags have been added, the MissingCovers sniff should be re-enabled in .phpcs.xml.

Details

	Subject	Repo	Branch	Lines +/-
	Add @covers to unit tests	mediawiki/extensions/ReadingLists	master	+17 -3

Customize query in gerrit

Related Objects

Mentioned In: rERLSd5bcd4c08026: Add @covers to unit tests

Event Timeline

Legoktm added projects: MediaWiki-extensions-Other, Test-Coverage.May 20 2018, 1:53 AM

Legoktm subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2018, 1:53 AM

I'm a bit surprised there's no project for the ReadingLists extension..?

Reading List Service (which covers both the extension and the RESTBase proxy). It's documented on the extension page; I'll add an alias.

Restricted Application added a project: Product-Infrastructure-Team-Backlog-Deprecated. · View Herald TranscriptMay 20 2018, 1:54 PM

Tgr moved this task from Needs triage to Backlog on the Product-Infrastructure-Team-Backlog-Deprecated board.May 20 2018, 1:54 PM

• Vvjjkkii renamed this task from ReadingLists extension is missing @covers tags to 8lcaaaaaaa.Jul 1 2018, 1:09 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from 8lcaaaaaaa to ReadingLists extension is missing @covers tags.Jul 1 2018, 5:06 PM

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

Change 455118 had a related patch set uploaded (by Legoktm; owner: Umherirrender):
[mediawiki/extensions/ReadingLists@master] Add @covers to unit tests

https://gerrit.wikimedia.org/r/455118

gerritbot added a project: Patch-For-Review.Aug 25 2018, 6:04 AM

Legoktm mentioned this in rERLSd5bcd4c08026: Add @covers to unit tests.Aug 25 2018, 6:08 AM

Change 455118 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@master] Add @covers to unit tests

https://gerrit.wikimedia.org/r/455118

Legoktm closed this task as Resolved.Aug 25 2018, 6:22 AM

Legoktm assigned this task to Umherirrender.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)).Aug 25 2018, 7:01 AM