Maniphest T195163

SpamBlacklist extension is missing @covers tags
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	May 20 2018, 1:53 AM

Description

PHPCS has identified that some of the SpamBlacklist PHPUnit tests are missing @covers tags. Those tags
are necessary for PHPUnit to accurately calculate test coverage.

See the PHPUnit documentation for how to use it.

Once the tags have been added, the MissingCovers sniff should be re-enabled in .phpcs.xml.

Details

	Subject	Repo	Branch	Lines +/-
	Add @covers to unit test	mediawiki/extensions/SpamBlacklist	master	+1 -1

Customize query in gerrit

Event Timeline

Legoktm added projects: SpamBlacklist, Test-Coverage.May 20 2018, 1:53 AM

Legoktm subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2018, 1:53 AM

• Vvjjkkii renamed this task from SpamBlacklist extension is missing @covers tags to 4lcaaaaaaa.Jul 1 2018, 1:08 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from 4lcaaaaaaa to SpamBlacklist extension is missing @covers tags.Jul 1 2018, 5:04 PM

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

Change 455124 had a related patch set uploaded (by Legoktm; owner: Umherirrender):
[mediawiki/extensions/SpamBlacklist@master] Add @covers to unit test

https://gerrit.wikimedia.org/r/455124

gerritbot added a project: Patch-For-Review.Aug 25 2018, 6:03 AM

Change 455124 merged by jenkins-bot:
[mediawiki/extensions/SpamBlacklist@master] Add @covers to unit test

https://gerrit.wikimedia.org/r/455124

Legoktm closed this task as Resolved.Aug 25 2018, 6:22 AM

Legoktm assigned this task to Umherirrender.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)).Aug 25 2018, 7:01 AM

SpamBlacklist extension is missing @covers tagsClosed, ResolvedPublicActions

Description

Details

Event Timeline

SpamBlacklist extension is missing @covers tags
Closed, ResolvedPublic
Actions