Page MenuHomePhabricator
Create Task
Maniphest T195164

TemplateData extension is missing @covers tags
Closed, ResolvedPublic
Actions

Description

PHPCS has identified that some of the TemplateData PHPUnit tests are missing @covers tags. Those tags
are necessary for PHPUnit to accurately calculate test coverage.

See the PHPUnit documentation for how to use it.

Once the tags have been added, the MissingCovers sniff should be re-enabled in .phpcs.xml.

Event Timeline

Legoktm added projects: TemplateData, Test-Coverage.May 20 2018, 1:53 AM
Legoktm subscribed.
Restricted Application added a project: VisualEditor. · View Herald TranscriptMay 20 2018, 1:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Deskana moved this task from To Triage to Freezer on the VisualEditor board.May 29 2018, 6:42 PM
• Vvjjkkii renamed this task from TemplateData extension is missing @covers tags to 3lcaaaaaaa.Jul 1 2018, 1:08 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from 3lcaaaaaaa to TemplateData extension is missing @covers tags.Jul 1 2018, 5:02 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
Umherirrender closed this task as Resolved.Aug 25 2018, 9:54 AM
Umherirrender assigned this task to Legoktm.
Umherirrender subscribed.

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/TemplateData/+/428863/

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 25 2018, 9:54 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL