Page MenuHomePhabricator
Create Task
Maniphest T195191

Cite menu option is missing on the Mobile VE toolbar
Closed, ResolvedPublic
Actions

Description

Cite menu option is missing on the Mobile VE toolbar.

Screen Shot 2018-05-20 at 1.21.57 PM.png (709×1 px, 138 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
MobileArticleTarget: Include placeholder for referencesmediawiki/extensions/VisualEditorwmf/1.32.0-wmf.5+4 -0
MobileArticleTarget: Include placeholder for referencesmediawiki/extensions/VisualEditormaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ryasmeen created this task.May 20 2018, 11:23 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2018, 11:23 AM
Ryasmeen added a parent task: T191051: 1.32.0-wmf.5 deployment blockers.May 20 2018, 11:25 AM
DLynch claimed this task.EditedMay 24 2018, 3:31 PM
DLynch edited projects, added VisualEditor (Current work); removed VisualEditor.
DLynch subscribed.

I'd assume fallout from a08febb0afa2d by @Esanders. Mostly because MobileArticleTarget never got an equivalent to 900b74e9a9 which lets it know where references are supposed to go in the toolbar.

gerritbot subscribed.May 24 2018, 3:35 PM

Change 434938 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] MobileArticleTarget: Include placeholder for references

https://gerrit.wikimedia.org/r/434938

gerritbot added a project: Patch-For-Review.May 24 2018, 3:35 PM
DLynch moved this task from Incoming to Code review on the VisualEditor (Current work) board.May 24 2018, 4:36 PM
gerritbot added a comment.May 24 2018, 5:30 PM

Change 434938 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MobileArticleTarget: Include placeholder for references

https://gerrit.wikimedia.org/r/434938

Jdforrester-WMF edited projects, added VisualEditor-MediaWiki-References, VisualEditor-MediaWiki-Mobile; removed Patch-For-Review.May 24 2018, 5:45 PM
Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).May 24 2018, 6:00 PM
gerritbot added a comment.May 24 2018, 7:16 PM

Change 434992 had a related patch set uploaded (by 20after4; owner: DLynch):
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.5] MobileArticleTarget: Include placeholder for references

https://gerrit.wikimedia.org/r/434992

gerritbot added a project: Patch-For-Review.May 24 2018, 7:16 PM
gerritbot added a comment.May 24 2018, 7:23 PM

Change 434992 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.5] MobileArticleTarget: Include placeholder for references

https://gerrit.wikimedia.org/r/434992

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)); removed MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).May 24 2018, 8:01 PM
Ryasmeen added a comment.May 24 2018, 10:05 PM

This is fixed on Beta cluster. However, it's still broken on test2 which is running wmf.5?

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)); removed MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), Patch-For-Review.May 24 2018, 10:58 PM

Yeah, the wmf.5 deploy didn't happen because of the production breakage.

• Deskana closed this task as Resolved.May 25 2018, 10:51 AM
• Deskana triaged this task as High priority.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 25 2018, 10:51 AM
Ryasmeen added projects: Verified, Verified-in-Phase0.May 31 2018, 11:19 PM
• Vvjjkkii renamed this task from Cite menu option is missing on the Mobile VE toolbar to clcaaaaaaa.Jul 1 2018, 1:08 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed DLynch as the assignee of this task.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from clcaaaaaaa to Cite menu option is missing on the Mobile VE toolbar.Jul 2 2018, 5:11 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to DLynch.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits