Change 434359 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[operations/mediawiki-config@master] Enable "File mover" flag on zh.wikipedia

https://gerrit.wikimedia.org/r/434359

Scheduled for deploy at Wednesday between 13:00–14:00 UTC.

@Zoranzoki21 There are some problems.

1. 3 lines should change movefile to filemover. (see comments on gerrit)
2. Filemover should be able to remove the right from themself only. They should not be able to remove others' right. ($wgGroupsRemoveFromSelf instead of $wgRemoveGroups)
3. You forgot to add the right movefile to the groups of patroller and autoreviewer.

Please check it again. Thanks.

@A2093064 Thank you for your code review. Please, when you're reviewing code from somebody else, always give Code-Review -1 to the patch so everyone will know it should not be merged before raised issues will be resolved. The CR-1 means nothing but information to the patch author and all who have the right to merge, no need to use them sparingly :). Thanks!

In T195247#4221723, @A2093064 wrote:

@Zoranzoki21 There are some problems.

1. 3 lines should change movefile to filemover. (see comments on gerrit)
2. Filemover should be able to remove the right from themself only. They should not be able to remove others' right. ($wgGroupsRemoveFromSelf instead of $wgRemoveGroups)
3. You forgot to add the right movefile to the groups of patroller and autoreviewer.

Please check it again. Thanks.

Thank you for drawing your attention. I will fix this and schedule at next week.. I can not to do before because of my health problems.

Change 434359 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable "File mover" flag on zh.wikipedia

https://gerrit.wikimedia.org/r/434359

Mentioned in SAL (#wikimedia-operations) [2018-05-28T14:00:46Z] <zfilipin@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:434359|Enable "File mover" flag on zh.wikipedia (T195247)]] (duration: 01m 19s)

In T195247#4236586, @Wong128hk wrote:

"please add the right "Move files (movefile)" to the groups of "patroller" and "autoreviewer"." Thank you very much.

Hi, I am back. I will add this.

Ok, it's back up to you.

In T195247#4239018, @Urbanecm wrote:

Ok, it's back up to you.

Doing that.. Patch coming

Change 436213 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[operations/mediawiki-config@master] Add filemover right to the groups of "patroller" and "autoreviewer on zhwiki

https://gerrit.wikimedia.org/r/436213

ummmmm...I am terribly sorry if my wordings confused you...

for now: the group of patroller bears the following right: (patrol) and (autopatrol)
Please add Move files (movefile) to the usergroup, so that it can become: (movefile), (patrol) and (autopatrol)

for now: the group of autoreviewer bears the following right: (autopatrol)
Please add Move files (movefile) to the usergroup, so that it can become: (movefile) and (autopatrol)

Thank you very much.

Could anybody please help modifying the code?

In T195247#4244955, @Wong128hk wrote:

Could anybody please help modifying the code?

I can push patch, but I can't join the SWAT deploy since I without free time.

I'm going to upload a new patch.

Change 436524 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Assign movefile to autoreviewrs and patrollers on zhwiki

https://gerrit.wikimedia.org/r/436524

In T195247#4244990, @RazeSoldier wrote:

In T195247#4244955, @Wong128hk wrote:

Could anybody please help modifying the code?

I can push patch, but I can't join the SWAT deploy since I without free time.

In future similar simple site requests (well, almost all site requests are simple), please feel free to just upload a patch, add my personal project User-Urbanecm and move the task to column called "To deploy - SWAT necessary" on my personal workboard and add a comment stating that you want me to schedule your patch for SWAT. I will review your patch and if it will be ok from my side, I'll schedule it for a SWAT I can be able in. This applies to you and everybody else who thinks that that times are hardly available.

Putting onto my radar.

In T195247#4245878, @Urbanecm wrote:

In future similar simple site requests (well, almost all site requests are simple), please feel free to just upload a patch, add my personal project User-Urbanecm and move the task to column called "To deploy - SWAT necessary" on my personal workboard and add a comment stating that you want me to schedule your patch for SWAT. I will review your patch and if it will be ok from my side, I'll schedule it for a SWAT I can be able in. This applies to you and everybody else who thinks that that times are hardly available.

Cool!

Change 436213 abandoned by Zoranzoki21:
Add filemover right to the groups of patroller and autoreviewer on zhwiki

Reason:
Per comment of user Urbanecm. Thank you!

https://gerrit.wikimedia.org/r/436213

Change 436524 merged by jenkins-bot:
[operations/mediawiki-config@master] Assign movefile to autoreviewrs and patrollers on zhwiki

https://gerrit.wikimedia.org/r/436524

Mentioned in SAL (#wikimedia-operations) [2018-06-04T13:11:23Z] <zfilipin@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:436524|Assign movefile to autoreviewrs and patrollers on zhwiki (T195247)]] (duration: 00m 52s)