Maniphest T195251

[BUG] App crashes when trying to enable offline library
Closed, InvalidPublic
Actions

Assigned To

None

Authored By

	Kaartic
	May 21 2018, 2:42 PM

Description

Steps to reproduce

Go to 'Settings'
Tap on the 'Enable Offline Library' switch

Expected results

The 'Offline Library' feature is enabled.

Actual results

The app crashes.

Stack trace

05-21 19:41:59.013 13979-13979/org.wikipedia.alpha D/ViewRootImpl: ViewPostImeInputStage ACTION_DOWN
05-21 19:41:59.123 13979-13979/org.wikipedia.alpha I/org.wikipedia.activity.BaseActivity: onRequestPermissionsResult():131: Write permission was denied by user
05-21 19:41:59.123 13979-13979/org.wikipedia.alpha D/AndroidRuntime: Shutting down VM05-21 19:41:59.133 13979-13979/org.wikipedia.alpha E/AndroidRuntime: FATAL EXCEPTION: main
                                                                     Process: org.wikipedia.alpha, PID: 13979
                                                                     java.lang.NoSuchMethodError: No virtual method shouldShowRequestPermissionRationale(Ljava/lang/String;)Z in class Landroid/support/v7/app/AppCompatActivity; or its super classes (declaration of 'android.support.v7.app.AppCompatActivity' appears in /data/app/org.wikipedia.alpha-2/split_lib_directories_apk.apk)
                                                                         at org.wikipedia.util.PermissionUtil.shouldShowWritePermissionRationale(PermissionUtil.java:30)
                                                                         at org.wikipedia.activity.BaseActivity.onRequestPermissionsResult(BaseActivity.java:133)
                                                                         at android.support.v4.app.ActivityCompat$1.run(ActivityCompat.java:524)
                                                                         at android.os.Handler.handleCallback(Handler.java:739)
                                                                         at android.os.Handler.dispatchMessage(Handler.java:95)
                                                                         at android.os.Looper.loop(Looper.java:145)
                                                                         at android.app.ActivityThread.main(ActivityThread.java:6934)
                                                                         at java.lang.reflect.Method.invoke(Native Method)
                                                                         at java.lang.reflect.Method.invoke(Method.java:372)
                                                                         at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1404)
                                                                         at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1199)

Environments observed

App version: 2.7.232-alpha-2018-05-21
Android OS versions: 5.1.1, API 22
Device model: Samsung Galaxy j1 ace
Device language:

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix: App crashes when trying to enable offline library in lower API	apps/android/wikipedia	master	+9 -8

Customize query in gerrit

Related Objects

Mentioned In: T195428: [BUG] App does not check the write permission correctly
Mentioned Here: T195518: Shelve Offline Library code for now.

Event Timeline

Kaartic created this task.May 21 2018, 2:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 21 2018, 2:42 PM

LGoto triaged this task as Low priority.May 21 2018, 4:14 PM

LGoto moved this task from Needs Triage to Bug Backlog on the Wikipedia-Android-App-Backlog board.

RHo added projects: Android-app-feature-Compilations, Android-app-feature-Compilations-v1.May 21 2018, 4:14 PM

Change 434820 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Fix: App crashes when trying to enable offline library in lower API

https://gerrit.wikimedia.org/r/434820

gerritbot added a project: Patch-For-Review.May 23 2018, 10:46 PM

cooltey claimed this task.May 23 2018, 10:46 PM

cooltey mentioned this in T195428: [BUG] App does not check the write permission correctly.May 23 2018, 11:19 PM

Change 434820 abandoned by Cooltey:
Fix: App crashes when trying to enable offline library in lower API

Reason:
Abandon due to stop supports offline library feature

https://gerrit.wikimedia.org/r/434820

cooltey removed cooltey as the assignee of this task.Jun 1 2018, 8:45 PM

cooltey subscribed.

No longer accepting bug tickets for Offline Library since the feature is currently shelved (T195518) and will likely be very different when brought back.

• Vvjjkkii renamed this task from [BUG] App crashes when trying to enable offline library to ojcaaaaaaa.Jul 1 2018, 1:10 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii raised the priority of this task from Low to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed the point value 1 for this task.

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

Kaartic renamed this task from ojcaaaaaaa to [BUG] App crashes when trying to enable offline library .Jul 1 2018, 1:30 PM

Kaartic closed this task as Invalid.

Kaartic lowered the priority of this task from High to Low.

Kaartic removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

Kaartic updated the task description. (Show Details)

Kaartic added subscribers: Aklapper, gerritbot.

[BUG] App crashes when trying to enable offline library Closed, InvalidPublicActions