Page MenuHomePhabricator
Create Task
Maniphest T195253

Special:Notifications gives a consistent PHP exception on load ("The trash icon is not registered") for users with OpenStackManager notifications
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To
Tgr
Authored By
jcrespo
May 21 2018, 3:15 PM
Tags
Referenced Files
F23899427: Screenshot_20180719_094319.png
Jul 19 2018, 7:43 AM
Subscribers
Addshore
Aklapper
Catrope
gerritbot
jcrespo
Jdforrester-WMF
JTannerWMF
View All 14 Subscribers

Description

If I visit https://wikitech.wikimedia.org/wiki/Special:Notifications,

I get every time an exception "InvalidArgumentException"

trace:

#0 /srv/mediawiki/php-1.32.0-wmf.3/extensions/Echo/includes/formatters/SpecialNotificationsFormatter.php(111): EchoIcon::getUrl(string, string)
#1 /srv/mediawiki/php-1.32.0-wmf.3/extensions/Echo/includes/formatters/SpecialNotificationsFormatter.php(18): SpecialNotificationsFormatter->getIconURL(EchoOpenStackManagerPresentationModel)
#2 /srv/mediawiki/php-1.32.0-wmf.3/extensions/Echo/includes/formatters/EchoEventFormatter.php(63): SpecialNotificationsFormatter->formatModel(EchoOpenStackManagerPresentationModel)
#3 /srv/mediawiki/php-1.32.0-wmf.3/extensions/Echo/includes/DataOutputFormatter.php(171): EchoEventFormatter->format(EchoEvent)
#4 /srv/mediawiki/php-1.32.0-wmf.3/extensions/Echo/includes/DataOutputFormatter.php(136): EchoDataOutputFormatter::formatNotification(EchoEvent, User, string, LanguageEn)
#5 /srv/mediawiki/php-1.32.0-wmf.3/extensions/Echo/includes/special/SpecialNotifications.php(59): EchoDataOutputFormatter::formatOutput(EchoNotification, string, User, LanguageEn)
#6 /srv/mediawiki/php-1.32.0-wmf.3/includes/specialpage/SpecialPage.php(522): SpecialNotifications->execute(NULL)
#7 /srv/mediawiki/php-1.32.0-wmf.3/includes/specialpage/SpecialPageFactory.php(568): SpecialPage->run(NULL)
#8 /srv/mediawiki/php-1.32.0-wmf.3/includes/MediaWiki.php(288): SpecialPageFactory::executePath(Title, RequestContext)
#9 /srv/mediawiki/php-1.32.0-wmf.3/includes/MediaWiki.php(861): MediaWiki->performRequest()
#10 /srv/mediawiki/php-1.32.0-wmf.3/includes/MediaWiki.php(524): MediaWiki->main()
#11 /srv/mediawiki/php-1.32.0-wmf.3/index.php(42): MediaWiki->run()
#12 /srv/mediawiki/w/index.php(3): include(string)
#13 {main}

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add trash icon that was removed from Echomediawiki/extensions/OpenStackManagerREL1_31+11 -1
Add trash icon that was removed from Echomediawiki/extensions/OpenStackManagermaster+11 -1
Handle missing presentation modelmediawiki/extensions/Echowmf/1.32.0-wmf.10+5 -4
Handle missing presentation modelmediawiki/extensions/Echomaster+5 -4
Revert "Revert "Revert "Remove unused 'trash' icon"""mediawiki/extensions/Echomaster+7 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT189531 All Wikimedia developer services should use single sign-on
 ResolvedNoneT161859 Make Wikitech an SUL wiki
 ResolvedPRODUCTION ERRORTgrT195253 Special:Notifications gives a consistent PHP exception on load ("The trash icon is not registered") for users with OpenStackManager notifications
 ResolvedtaaviT161553 Remove OpenStackManager from Wikitech
 ResolvedAndrewT150091 Support project creation without OpenStackManager
 ResolvedAndrewT159021 Wikitech error when adding users to projects
 ResolvedAndrewT162097 Create a Horizon panel for managing per-project sudo policies
 ResolvedAndrewT194191 Allow projectadmins to change project roles in Horizon
 ResolvedMarcoAurelioT194670 Copy maintenance/attachLdapUser.php to another extension
 ResolvedAndrewT194794 Add new users to Bastion group whenever they join a project
 ResolvedtaaviT196171 Developer account creation without OpenStackManager
 DeclinedNoneT179463 Create a single application to provision and manage developer (LDAP) accounts
 DuplicateNoneT189639 Separate LDAP account creation bits from Striker to create a new identity management platform
 ResolvedNoneT319405 Create an IDM for Wikimedia developer accounts
 ResolvedSLyngshede-WMFT319407 IDM milestone 1 "Initial development work"
 ResolvedNoneT319409 Pick a name for the IDM
 ResolvedSLyngshede-WMFT319410 Initial Django project setup
 ResolvedSLyngshede-WMFT319415 Evaluate Striker codebase
 ResolvedMarosteguiT320426 Figure out where/how to store IDM internal data
 ResolvedSLyngshede-WMFT320427 Design and implement async LDAP operations
 ResolvedSLyngshede-WMFT320428 Initial IDM puppetisation
 ResolvedSLyngshede-WMFT320430 Create an initial IDM/LDAP image for tests and CI
 ResolvedSLyngshede-WMFT320431 IDM: Central logging on all changes
 ResolvedSLyngshede-WMFT320603 IDM milestone 2 "Initial limited deployment"
 ResolvedSLyngshede-WMFT320604 Decide on model for serving idm.wikimedia.org
 ResolvedNoneT320605 Figure out an HA setup for the IDM
 ResolvedSLyngshede-WMFT320794 Extend LDAP to allow storing all necessary attributes
 ResolvedSLyngshede-WMFT320795 Implement a staging setup for the IDM
 ResolvedSLyngshede-WMFT320797 Initial production deployment of the IDM
 ResolvedSLyngshede-WMFT320799 IDM integration into CAS SSO
 ResolvedSLyngshede-WMFT320807 Implement OAuth account validation for linking an account to a wiki account
 ResolvedSLyngshede-WMFT320808 Implement email address validation workflow
 OpenNoneT148048 Store Wikimedia unified account name (SUL) in LDAP directory
 OpenNoneT359428 Striker should use ID instead of username to identify SUL accounts
 Resolvedbd808T403906 Unlink SUL account JosefAnthony from Developer account josef1992
 ResolvedSLyngshede-WMFT335091 Determine which sender address to use for email notification
 ResolvedSLyngshede-WMFT340721 Build Debian packages for Bookworm
 ResolvedSLyngshede-WMFT340722 Update IDM servers to Bookworm
 OpenSLyngshede-WMFT320801 Build-out for self service
 ResolvedSLyngshede-WMFT320802 Create a mockup and involve designers
 ResolvedBUG REPORTSLyngshede-WMFT338824 Bitu is not responsive
 InvalidNoneT320805 Define the core attribute list managed in the IDM with all stakeholders
 ResolvedSLyngshede-WMFT320806 Consider reusing some wiki data sources for signup/restrictions
 ResolvedSLyngshede-WMFT320809 Figure out a captcha option for IDM
 OpenNoneT335478 Automatic detection of inactive LDAP account
 OpenNoneT335485 Automatically deploy documentation to docs.wikimedia.org
 ResolvedSLyngshede-WMFT340636 Implement "Forgot my username" feature
 ResolvedSLyngshede-WMFT340637 Implement "update email" functionality
 OpenSLyngshede-WMFT340717 Implement "source" field on user objects
 OpenSLyngshede-WMFT345168 Live validation of usernames
 ResolvedSLyngshede-WMFT345226 Switch developer account creation to Bitu
 OpenSLyngshede-WMFT347572 SSH Key type expiry
 ResolvedtaaviT338477 `Nova Resource:` namespace should be declared in wmf-config, not in Extension:OpenStackManager
 ResolvedtaaviT359544 Disable SSH key management on Wikitech
 ResolvedFeatureSLyngshede-WMFT359543 Allow enabling a key directly when adding it
 ResolvedBUG REPORTSLyngshede-WMFT360634 Bitu not importing key changes directly in LDAP

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMay 21 2018, 3:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
jcrespo added a project: wikitech.wikimedia.org.May 21 2018, 3:17 PM
Paladox subscribed.EditedMay 21 2018, 3:51 PM

I guess this is caused by https://github.com/wikimedia/mediawiki-extensions-Echo/commit/ee44f96e2f91c8e6d4009ed61517d2333bba718c ?

gerritbot subscribed.May 21 2018, 3:52 PM

Change 434349 had a related patch set uploaded (by Paladox; owner: Paladox):
[mediawiki/extensions/Echo@master] Revert "Revert "Revert "Remove unused 'trash' icon"""

https://gerrit.wikimedia.org/r/434349

gerritbot added a project: Patch-For-Review.May 21 2018, 3:52 PM
jcrespo added a subscriber: Catrope.May 21 2018, 4:05 PM
jcrespo mentioned this in T195288: Local exception for notifications does not work.May 23 2018, 4:10 PM
Jdforrester-WMF subscribed.May 23 2018, 9:36 PM

EchoOpenStackManagerPresentationModel will no longer be loaded on wikitechwiki once T161553: Remove OpenStackManager from Wikitech is deployed, so this error will turn into something else; either the notifications from OSM just won't show up, or there'll be a fatal from it not being able to find a formatter for that kind of notification. Lovely.

gerritbot added a comment.May 23 2018, 9:36 PM

Change 434349 abandoned by Jforrester:
Revert "Revert "Revert "Remove unused 'trash' icon"""

Reason:
Fix OpenStackManager to not depend on this icon.

https://gerrit.wikimedia.org/r/434349

Jdforrester-WMF renamed this task from Special:Notifications gives a consistent exception on load ("The trash icon is not registered") to Special:Notifications gives a consistent PHP exception on load ("The trash icon is not registered") for users with OpenStackManager notifications.May 23 2018, 10:24 PM
Jdforrester-WMF edited projects, added MediaWiki-extensions-OpenStackManager; removed Patch-For-Review.
JTannerWMF edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.May 30 2018, 6:17 PM
JTannerWMF subscribed.

@Catrope reminder: you wanted to talk to James @Jdforrester-WMF

JTannerWMF moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.May 30 2018, 6:17 PM
zhuyifei1999 merged a task: T196035: "InvalidArgumentException: The trash icon is not registered" for Special:Notifications on Wikitech.May 31 2018, 11:08 AM
zhuyifei1999 added a subscriber: • MusikAnimal.
Addshore subscribed.Jun 1 2018, 9:10 AM
jcrespo added a subtask: T161553: Remove OpenStackManager from Wikitech.Jun 1 2018, 3:31 PM
• Vvjjkkii renamed this task from Special:Notifications gives a consistent PHP exception on load ("The trash icon is not registered") for users with OpenStackManager notifications to mjcaaaaaaa.Jul 1 2018, 1:08 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
TerraCodes renamed this task from mjcaaaaaaa to Special:Notifications gives a consistent PHP exception on load ("The trash icon is not registered") for users with OpenStackManager notifications.Jul 1 2018, 1:00 PM
TerraCodes raised the priority of this task from High to Needs Triage.
TerraCodes removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
TerraCodes updated the task description. (Show Details)
TerraCodes added subscribers: Aklapper, gerritbot.
gerritbot added a comment.Jul 3 2018, 4:53 PM

Change 443655 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/Echo@master] Handle missing presentation model

https://gerrit.wikimedia.org/r/443655

gerritbot added a project: Patch-For-Review.Jul 3 2018, 4:53 PM
SBisson subscribed.Jul 3 2018, 4:55 PM
In T195253#4394912, @gerritbot wrote:

Change 443655 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/Echo@master] Handle missing presentation model

https://gerrit.wikimedia.org/r/443655

This change will make the OSM notifications go away without a fight when the extension is undeployed. It does not address the missing icon error.

gerritbot added a comment.Jul 3 2018, 7:37 PM

Change 443655 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Handle missing presentation model

https://gerrit.wikimedia.org/r/443655

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 3 2018, 8:00 PM
Jdforrester-WMF assigned this task to SBisson.Jul 3 2018, 8:43 PM
Jdforrester-WMF moved this task from Ready for Pickup to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Jul 5 2018, 10:55 PM

Change 444136 had a related patch set uploaded (by Catrope; owner: Sbisson):
[mediawiki/extensions/Echo@wmf/1.32.0-wmf.10] Handle missing presentation model

https://gerrit.wikimedia.org/r/444136

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 5 2018, 10:55 PM
gerritbot added a project: Patch-For-Review.Jul 5 2018, 10:55 PM
gerritbot added a comment.Jul 5 2018, 11:40 PM

Change 444136 merged by jenkins-bot:
[mediawiki/extensions/Echo@wmf/1.32.0-wmf.10] Handle missing presentation model

https://gerrit.wikimedia.org/r/444136

Stashbot subscribed.Jul 5 2018, 11:47 PM

Mentioned in SAL (#wikimedia-operations) [2018-07-05T23:47:51Z] <catrope@deploy1001> Synchronized php-1.32.0-wmf.10/extensions/Echo/: Handle missing presentation model (T195253) (duration: 00m 52s)

Krinkle moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Jul 5 2018, 11:54 PM
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jul 6 2018, 12:01 AM
Jdforrester-WMF removed a project: Patch-For-Review.Jul 6 2018, 12:40 AM
Etonkovidova moved this task from QA Review to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 6 2018, 6:55 PM
JTannerWMF moved this task from Inbox to Needs Discussion on the Growth-Team board.Jul 10 2018, 5:30 PM
Aklapper merged a task: T199300: Fatal exception of type "InvalidArgumentException" at wikitech.wikimedia.org/wiki/Special:Notifications.Jul 11 2018, 9:47 AM
Aklapper added a subscriber: zeljkofilipin.
zeljkofilipin awarded a token.Jul 11 2018, 10:11 AM
JTannerWMF moved this task from Needs Discussion to Q1 2018-19 on the Growth-Team board.Jul 18 2018, 6:13 PM
Krinkle closed this task as Resolved.Jul 18 2018, 11:33 PM
jcrespo added a comment.Jul 19 2018, 7:24 AM

I am guessing this has been released, but wikitech needs to be upgraded still?

Jdforrester-WMF added a comment.Jul 19 2018, 7:35 AM
In T195253#4437033, @jcrespo wrote:

I am guessing this has been released, but wikitech needs to be upgraded still?

This code went to wikitechwiki on 2018-06-27 (but it was bumpy):

19:16 dduvall@deploy1001: Synchronized php: group1 wikis to 1.32.0-wmf.10 (duration: 00m 58s)
19:52 marxarelli: Rolling back group1 due to rise in error rate (T198350)
[-28]
19:17 dduvall@deploy1001: Synchronized php: Group1 (less commons) to 1.32.0-wmf.10 (duration: 00m 57s)

Is it not fixed for you?

jcrespo added a comment.Jul 19 2018, 7:43 AM
In T195253#4437069, @Jdforrester-WMF wrote:

Is it not fixed for you?

Screenshot_20180719_094319.png (983×1 px, 123 KB)

Time is UTC.

Aklapper added a comment.Jul 19 2018, 8:03 AM
In T195253#4437069, @Jdforrester-WMF wrote:

Is it not fixed for you?

Does not work for me either yet on https://wikitech.wikimedia.org/wiki/Special:Notifications , right now:
[33d5d11de7c35ae97e407f9a] 2018-07-19 08:02:18: Fatal exception of type "InvalidArgumentException"

Jdforrester-WMF added a comment.Jul 19 2018, 8:53 AM

Oh, sorry, yes, this is fixed as soon as T161553: Remove OpenStackManager from Wikitech is actually done.

Tgr reopened this task as Open.Jul 26 2018, 5:55 PM
Tgr subscribed.

In other words, not fixed.

gerritbot added a comment.Jul 26 2018, 6:01 PM

Change 448082 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/OpenStackManager@master] Add trash icon that was removed from Echo

https://gerrit.wikimedia.org/r/448082

gerritbot added a project: Patch-For-Review.Jul 26 2018, 6:01 PM
SBisson reassigned this task from SBisson to Tgr.Jul 26 2018, 7:10 PM
SBisson edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
SBisson moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Jul 26 2018, 7:17 PM

Change 448082 merged by jenkins-bot:
[mediawiki/extensions/OpenStackManager@master] Add trash icon that was removed from Echo

https://gerrit.wikimedia.org/r/448082

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)); removed MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jul 26 2018, 8:00 PM
Tgr closed this task as Resolved.Jul 26 2018, 9:19 PM
zeljkofilipin added a comment.Aug 1 2018, 12:55 PM

Um, I still get this at https://wikitech.wikimedia.org/wiki/Special:Notifications

Internal error
[3880905b81be8e1c386c6b6a] 2018-08-01 12:52:49: Fatal exception of type "InvalidArgumentException"

zeljkofilipin added a comment.Aug 1 2018, 12:55 PM

Is it because T161553 is still open?

Tgr added a comment.Aug 1 2018, 1:20 PM

I don't think wikitech uses train deploys.

Tgr added a comment.Aug 1 2018, 1:22 PM

It actually does. So this should get fixed today.

Zoglun mentioned this in T215688: Create a "Moegirlpedia" tag in Phabricator?.Feb 9 2019, 6:19 AM
Zoglun subscribed.Feb 11 2019, 7:51 AM

The bug still exist in extension:echo 1.31 version (commit rECHOb56ec9b435c5 Oct/12-2018). The Mediawiki 1.31 is a LTS version. Thus we wish the fix for this bug in Echo could get merged into REL1_31 branch.
Thank you in advance!

Jdforrester-WMF added a comment.Feb 11 2019, 4:09 PM
In T195253#4942452, @Zoglun wrote:

The bug still exist in extension:echo 1.31 version (commit rECHOb56ec9b435c5 Oct/12-2018). The Mediawiki 1.31 is a LTS version. Thus we wish the fix for this bug in Echo could get merged into REL1_31 branch.
Thank you in advance!

You should absolutely not be using the abandonware OpenStackManager, which is the only circumstance in which this would be an issue. However, if you really are, you should cherry-pick https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OpenStackManager/+/448082 on top of the REL1_31 branch.

Tgr added a comment.Feb 11 2019, 4:38 PM
In T195253#4944023, @Jdforrester-WMF wrote:

You should absolutely not be using the abandonware OpenStackManager, which is the only circumstance in which this would be an issue.

If it's really abandonware we should change its state to unmaintained. Doesn't really affect LTS support issues though.

gerritbot added a comment.Feb 11 2019, 4:39 PM

Change 489728 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/OpenStackManager@REL1_31] Add trash icon that was removed from Echo

https://gerrit.wikimedia.org/r/489728

gerritbot added a comment.Feb 12 2019, 12:21 AM

Change 489728 merged by Gergő Tisza:
[mediawiki/extensions/OpenStackManager@REL1_31] Add trash icon that was removed from Echo

https://gerrit.wikimedia.org/r/489728

Zoglun mentioned this in T216973: Fatal error in echo notification.Feb 25 2019, 12:22 AM
Liuxinyu970226 subscribed.Feb 25 2019, 1:13 AM

@Jdforrester-WMF:

In T195253#4942452, @Zoglun wrote:

The bug still exist in extension:echo 1.31 version (commit rECHOb56ec9b435c5 Oct/12-2018). The Mediawiki 1.31 is a LTS version. Thus we wish the fix for this bug in Echo could get merged into REL1_31 branch.
Thank you in advance!

You should absolutely not be using the abandonware OpenStackManager, which is the only circumstance in which this would be an issue. However, if you really are, you should cherry-pick https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OpenStackManager/+/448082 on top of the REL1_31 branch.

This bug can still happened even without that extension. See the referenced task.

Liuxinyu970226 unsubscribed.Feb 25 2019, 1:13 AM
Reedy removed a project: Patch-For-Review.May 17 2019, 9:43 PM
Krinkle moved this task from Dec2019/1.35.wmf.10+ to Resolved on the Wikimedia-production-error board.May 29 2019, 4:00 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM
taavi closed subtask T161553: Remove OpenStackManager from Wikitech as Resolved.Jun 19 2024, 5:54 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits