Page MenuHomePhabricator

Special:Notifications gives a consistent PHP exception on load ("The trash icon is not registered") for users with OpenStackManager notifications
Closed, ResolvedPublicPRODUCTION ERROR

Description

If I visit https://wikitech.wikimedia.org/wiki/Special:Notifications,

I get every time an exception "InvalidArgumentException"

trace:

#0 /srv/mediawiki/php-1.32.0-wmf.3/extensions/Echo/includes/formatters/SpecialNotificationsFormatter.php(111): EchoIcon::getUrl(string, string)
#1 /srv/mediawiki/php-1.32.0-wmf.3/extensions/Echo/includes/formatters/SpecialNotificationsFormatter.php(18): SpecialNotificationsFormatter->getIconURL(EchoOpenStackManagerPresentationModel)
#2 /srv/mediawiki/php-1.32.0-wmf.3/extensions/Echo/includes/formatters/EchoEventFormatter.php(63): SpecialNotificationsFormatter->formatModel(EchoOpenStackManagerPresentationModel)
#3 /srv/mediawiki/php-1.32.0-wmf.3/extensions/Echo/includes/DataOutputFormatter.php(171): EchoEventFormatter->format(EchoEvent)
#4 /srv/mediawiki/php-1.32.0-wmf.3/extensions/Echo/includes/DataOutputFormatter.php(136): EchoDataOutputFormatter::formatNotification(EchoEvent, User, string, LanguageEn)
#5 /srv/mediawiki/php-1.32.0-wmf.3/extensions/Echo/includes/special/SpecialNotifications.php(59): EchoDataOutputFormatter::formatOutput(EchoNotification, string, User, LanguageEn)
#6 /srv/mediawiki/php-1.32.0-wmf.3/includes/specialpage/SpecialPage.php(522): SpecialNotifications->execute(NULL)
#7 /srv/mediawiki/php-1.32.0-wmf.3/includes/specialpage/SpecialPageFactory.php(568): SpecialPage->run(NULL)
#8 /srv/mediawiki/php-1.32.0-wmf.3/includes/MediaWiki.php(288): SpecialPageFactory::executePath(Title, RequestContext)
#9 /srv/mediawiki/php-1.32.0-wmf.3/includes/MediaWiki.php(861): MediaWiki->performRequest()
#10 /srv/mediawiki/php-1.32.0-wmf.3/includes/MediaWiki.php(524): MediaWiki->main()
#11 /srv/mediawiki/php-1.32.0-wmf.3/index.php(42): MediaWiki->run()
#12 /srv/mediawiki/w/index.php(3): include(string)
#13 {main}

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
ResolvedPRODUCTION ERRORTgr
OpenNone
ResolvedAndrew
ResolvedAndrew
ResolvedAndrew
ResolvedAndrew
ResolvedMarcoAurelio
ResolvedAndrew
Resolvedtaavi
DeclinedNone
DuplicateNone
OpenNone
ResolvedSLyngshede-WMF
ResolvedNone
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedMarostegui
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedNone
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
Openbd808
Opentaavi
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
OpenSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedBUG REPORTSLyngshede-WMF
InvalidNone
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
OpenNone
OpenNone
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
OpenSLyngshede-WMF
OpenSLyngshede-WMF
ResolvedSLyngshede-WMF
OpenSLyngshede-WMF
OpenNone
OpenNone
OpenFeatureNone

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 434349 had a related patch set uploaded (by Paladox; owner: Paladox):
[mediawiki/extensions/Echo@master] Revert "Revert "Revert "Remove unused 'trash' icon"""

https://gerrit.wikimedia.org/r/434349

EchoOpenStackManagerPresentationModel will no longer be loaded on wikitechwiki once T161553: Remove OpenStackManager from Wikitech is deployed, so this error will turn into something else; either the notifications from OSM just won't show up, or there'll be a fatal from it not being able to find a formatter for that kind of notification. Lovely.

Change 434349 abandoned by Jforrester:
Revert "Revert "Revert "Remove unused 'trash' icon"""

Reason:
Fix OpenStackManager to not depend on this icon.

https://gerrit.wikimedia.org/r/434349

Jdforrester-WMF renamed this task from Special:Notifications gives a consistent exception on load ("The trash icon is not registered") to Special:Notifications gives a consistent PHP exception on load ("The trash icon is not registered") for users with OpenStackManager notifications.May 23 2018, 10:24 PM
Vvjjkkii renamed this task from Special:Notifications gives a consistent PHP exception on load ("The trash icon is not registered") for users with OpenStackManager notifications to mjcaaaaaaa.Jul 1 2018, 1:08 AM
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed subscribers: gerritbot, Aklapper.
TerraCodes renamed this task from mjcaaaaaaa to Special:Notifications gives a consistent PHP exception on load ("The trash icon is not registered") for users with OpenStackManager notifications.Jul 1 2018, 1:00 PM
TerraCodes raised the priority of this task from High to Needs Triage.
TerraCodes updated the task description. (Show Details)
TerraCodes added subscribers: Aklapper, gerritbot.

Change 443655 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/Echo@master] Handle missing presentation model

https://gerrit.wikimedia.org/r/443655

Change 443655 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/Echo@master] Handle missing presentation model

https://gerrit.wikimedia.org/r/443655

This change will make the OSM notifications go away without a fight when the extension is undeployed. It does not address the missing icon error.

Change 443655 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Handle missing presentation model

https://gerrit.wikimedia.org/r/443655

Change 444136 had a related patch set uploaded (by Catrope; owner: Sbisson):
[mediawiki/extensions/Echo@wmf/1.32.0-wmf.10] Handle missing presentation model

https://gerrit.wikimedia.org/r/444136

Change 444136 merged by jenkins-bot:
[mediawiki/extensions/Echo@wmf/1.32.0-wmf.10] Handle missing presentation model

https://gerrit.wikimedia.org/r/444136

Mentioned in SAL (#wikimedia-operations) [2018-07-05T23:47:51Z] <catrope@deploy1001> Synchronized php-1.32.0-wmf.10/extensions/Echo/: Handle missing presentation model (T195253) (duration: 00m 52s)

I am guessing this has been released, but wikitech needs to be upgraded still?

I am guessing this has been released, but wikitech needs to be upgraded still?

This code went to wikitechwiki on 2018-06-27 (but it was bumpy):

19:16 dduvall@deploy1001: Synchronized php: group1 wikis to 1.32.0-wmf.10 (duration: 00m 58s)
19:52 marxarelli: Rolling back group1 due to rise in error rate (T198350)
[-28]
19:17 dduvall@deploy1001: Synchronized php: Group1 (less commons) to 1.32.0-wmf.10 (duration: 00m 57s)

Is it not fixed for you?

Is it not fixed for you?

Screenshot_20180719_094319.png (983×1 px, 123 KB)

Time is UTC.

Is it not fixed for you?

Does not work for me either yet on https://wikitech.wikimedia.org/wiki/Special:Notifications , right now:
[33d5d11de7c35ae97e407f9a] 2018-07-19 08:02:18: Fatal exception of type "InvalidArgumentException"

Tgr added a subscriber: Tgr.

In other words, not fixed.

Change 448082 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/OpenStackManager@master] Add trash icon that was removed from Echo

https://gerrit.wikimedia.org/r/448082

Change 448082 merged by jenkins-bot:
[mediawiki/extensions/OpenStackManager@master] Add trash icon that was removed from Echo

https://gerrit.wikimedia.org/r/448082

Um, I still get this at https://wikitech.wikimedia.org/wiki/Special:Notifications

Internal error
[3880905b81be8e1c386c6b6a] 2018-08-01 12:52:49: Fatal exception of type "InvalidArgumentException"

I don't think wikitech uses train deploys.

It actually does. So this should get fixed today.

The bug still exist in extension:echo 1.31 version (commit b56ec9b435c52a744cf7bdc3217e752df8742238 Oct/12-2018). The Mediawiki 1.31 is a LTS version. Thus we wish the fix for this bug in Echo could get merged into REL1_31 branch.
Thank you in advance!

The bug still exist in extension:echo 1.31 version (commit b56ec9b435c52a744cf7bdc3217e752df8742238 Oct/12-2018). The Mediawiki 1.31 is a LTS version. Thus we wish the fix for this bug in Echo could get merged into REL1_31 branch.
Thank you in advance!

You should absolutely not be using the abandonware OpenStackManager, which is the only circumstance in which this would be an issue. However, if you really are, you should cherry-pick https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OpenStackManager/+/448082 on top of the REL1_31 branch.

You should absolutely not be using the abandonware OpenStackManager, which is the only circumstance in which this would be an issue.

If it's really abandonware we should change its state to unmaintained. Doesn't really affect LTS support issues though.

Change 489728 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/OpenStackManager@REL1_31] Add trash icon that was removed from Echo

https://gerrit.wikimedia.org/r/489728

Change 489728 merged by Gergő Tisza:
[mediawiki/extensions/OpenStackManager@REL1_31] Add trash icon that was removed from Echo

https://gerrit.wikimedia.org/r/489728

@Jdforrester-WMF:

The bug still exist in extension:echo 1.31 version (commit b56ec9b435c52a744cf7bdc3217e752df8742238 Oct/12-2018). The Mediawiki 1.31 is a LTS version. Thus we wish the fix for this bug in Echo could get merged into REL1_31 branch.
Thank you in advance!

You should absolutely not be using the abandonware OpenStackManager, which is the only circumstance in which this would be an issue. However, if you really are, you should cherry-pick https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OpenStackManager/+/448082 on top of the REL1_31 branch.

This bug can still happened even without that extension. See the referenced task.

mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM