Page MenuHomePhabricator
Create Task
Maniphest T195280

New Gerrit UI does not contain copyable Change-Id or parent commit id
Closed, ResolvedPublic
Actions

Description

In Gerrit there is an option to copy Change-Id, commit id and parrent commit id. But in new Gerrit UI, this option is missing completely. Change-Id can be found in the commit message, but parent id can not be found anywhere (T195278). And those simple copyable text fields from the old Gerrit UI are missing completely.

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT195280 New Gerrit UI does not contain copyable Change-Id or parent commit id
 ResolvedQChrisT254158 Gerrit 3.2 upgrade
 ResolvedQChrisT254155 Make sure we backup Gerrit's LFS data
 ResolvedDzahnT239151 Gerrit VM to test data migration
 ResolvedthciprianiT243808 gerrit1002 running out of space
 ResolvedAklapperT227562 Update Gerrit documentation on user interface for Gerrit 3.2 on mediawiki.org
 ResolvedAklapperT256867 Update three Gerrit documentation pages on mediawiki.org after Gerrit 3.2 update
 ResolvedQChrisT243982 Test backup and restore of Gerrit data
 ResolvedDzahnT243983 Add second virtual hard disk to ganeti gerrit test instance
 ResolvedQChrisT254162 Initial backup run for Gerrit LFS data
 ResolvedQChrisT254642 Verify upgrade to Gerrit 3.x will work on test hardware.
 ResolvedjcrespoT254516 Get a writable reviewdb clone to test Gerrit upgrade with
 ResolvedDzahnT254644 Set up test instance for the community to test new version
 ResolvedPaladoxT227509 Prepare Gerrit site template for upcoming Gerrit 3.x upgrade
 ResolvedQChrisT254648 Double check that `Code of Conduct` and `Privacy` links are in place after site update for Gerrit 3.x
 ResolvedQChrisT254651 Make sure currently used barricade functionality is available in our used Gerrit 3.x build
 ResolvedQChrisT254652 Provide an easy way to see which plugin is used in which version and API on a gerrit server.
 ResolvedQChrisT254654 Allow to see API version of used in Gerrit
 ResolvedQChrisT254655 Bring API version number into Gerrit plugins
 ResolvedQChrisT254656 Switch Gerrit plugin version numbers from plain hashes to more descriptive variants
 ResolvedQChrisT254657 Make sure `its-phabricator` exposes the `its-base` version that got used for building
 ResolvedQChrisT254659 Update `its-phabricator` to Gerrit 3.x
 ResolvedQChrisT254660 Make `its-base` fit for Gerrit 3.x
 ResolvedBUG REPORTQChrisT255977 Gerrit 3.x test instance loads content from third-party website fonts.gstatic.com
 InvalidBUG REPORTNoneT256077 Enabled dark mode no works on changing browser
 ResolvedDzahnT256404 Add qchris to `archiva-deployers` so he can upload artifacts for gerrit deployments
 ResolvedBUG REPORTkostajhT256474 On iOS toggling the "Only comments" switch don't seem to work on gerrit-test.wikimedia.org
 ResolvedBUG REPORTQChrisT256506 Gitiles on Gerrit 3.2 test instance loads fonts from third-party domain
 ResolvedBUG REPORTQChrisT256550 In Gerrit 3.2 a change without related changes does not show Depends-On and Needed-By
 InvalidBUG REPORTNoneT256560 Plugin install error shown when loading a page (`Plugin install error: TypeError: self.onAction ... delete-project.js`)
 ResolvedBUG REPORTQChrisT256571 Since Gerrit 3.2, gitiles monospaced text is bold
 DeclinedNoneT256575 Jenkins comments no longer formatted on Gerrit 3
 InvalidNoneT256601 Hide the "Monitoring" tab?
 OpenNoneT256615 "CR" and "V" columns are not colorblind-friendly
 DuplicateBUG REPORTNoneT256631 Plugin install error: TypeError: self.onAction is not a function from https://gerrit.wikimedia.org/r/plugins/delete-project/static/delete-project.js
 DeclinedNoneT256588 Gerrit commit message body wrapped near 80 characters instead 100
 ResolvedNikerabbitT256624 Unable to automerge exported i18n patched
 DeclinedBUG REPORTNoneT256633 Some merged patch sets does not show the last Code-Review+2 vote in Gerrit3
 ResolvedhasharT256653 gerrit: submitting a topic requires push option (.../master%topic=my-topic), appending to branch (.../master/my-topic) is no longer supported in Gerrit 3.2
 InvalidNoneT256671 Gerrit: Permission error "use a SHA1 visible to you, or get update permission on the ref" or "You need 'Create' rights to create new references." when using git-review ≤1.26
 ResolvedQChrisT256729 gerritbot comment URLs replace + with space
 DeclinedNoneT256961 gerrit 3.2.2 doesn't work with IE 11
 DeclinedNoneT256964 Gerrit commit message body is always wrapped with MS Edge
 DuplicateNoneT256963 gerrit plugin error: self.onAction is not a function
 DuplicateNoneT256967 gerrit 3.2.2: Plugin install error with Safari 13
 ResolvedBUG REPORTQChrisT257077 Clicking on entries in Gerrit's "show blame" view results in 404
 ResolvedQChrisT257186 Microsoft Edge does not display review details
 ResolvedQChrisT257198 Gerrit: `Depends on` and `Needed by` show `ChangeId`s, while other related changes show subject
 DeclinedNoneT257459 Depends-On did not block manual merging of a patch
 OpenNoneT257705 Horizontal scrollbars are missing when needed in Gerrit
 ResolvedDzahnT257609 upgrade git-review to >= 1.27 on all stretch hosts across the board
Restricted Task
Restricted Task
 ResolvedQChrisT258102 Gerrit is giving tips on how to write comments, make sure it does not send our comments to some third party

Event Timeline

Dvorapa created this task.May 22 2018, 5:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 22 2018, 5:59 AM
Dvorapa moved this task from Bugs & stuff to PolyGerrit on the Gerrit board.May 22 2018, 5:59 AM
Dvorapa updated the task description. (Show Details)
Paladox subscribed.May 22 2018, 11:26 AM

"parent commit id" that will be fixed in gerrit 2.16 / 3.0.

For "Change-Id" i doin't think they have done that yet.

Lucas_Werkmeister_WMDE mentioned this in T195278: New Gerrit UI does not show parent commit anywhere.May 22 2018, 5:05 PM
Peachey88 added a project: Upstream.May 22 2018, 8:18 PM
Paladox added a comment.May 22 2018, 8:20 PM

filled upstream at https://bugs.chromium.org/p/gerrit/issues/detail?id=9062 for "no copyable Change-Id" part

• Vvjjkkii renamed this task from New Gerrit UI does not contain copyable Change-Id or parent commit id to vicaaaaaaa.Jul 1 2018, 1:08 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from vicaaaaaaa to New Gerrit UI does not contain copyable Change-Id or parent commit id.Jul 2 2018, 3:59 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
Paladox added a subtask: T200739: Upgrade to Gerrit 2.16.13.Jul 31 2018, 12:02 AM
Paladox moved this task from PolyGerrit to Maybe fixed? on the Gerrit board.Oct 8 2018, 4:02 PM
Apap04 subscribed.Jan 15 2020, 11:15 PM

upstream issue set to WontFix, should a plugin be needed?

Aklapper moved this task from Backlog to Reported Upstream on the Upstream board.Jan 16 2020, 9:14 AM
cscott subscribed.May 2 2020, 4:08 AM
In T195280#5807751, @Apap04 wrote:

upstream issue set to WontFix, should a plugin be needed?

It seems to me that the change-id in the commit message is good enough. It was the missing parent id which was the real problem.

Dvorapa closed this task as Resolved.EditedMay 2 2020, 8:07 AM

If I look into Gerrit 3.1.4, it contains copyable parent sha and commit sha, only Change-Id does not have this button. And missing Change-Id button issue has been closed as WontFix, so this is resolved as far as I can tell.

Jdforrester-WMF closed subtask T200739: Upgrade to Gerrit 2.16.13 as Declined.Jun 4 2020, 8:14 PM
Paladox edited subtasks, added: T254158: Gerrit 3.2 upgrade; removed: T200739: Upgrade to Gerrit 2.16.13.Jun 4 2020, 8:29 PM
hashar closed subtask T254158: Gerrit 3.2 upgrade as Resolved.Sep 6 2020, 10:32 PM
hashar moved this task from Maybe fixed? to Bugs & stuff on the Gerrit board.Mar 1 2023, 10:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL