Page MenuHomePhabricator
Create Task
Maniphest T195327

Normalise the Accept-Language header for REST API requests
Closed, ResolvedPublic
Actions

Description

In order to be able to efficiently serve language variants from the REST API, we need to normalise the HTTP Accept-Language header for incoming requests. Given that the number of wikis that actually support language variants is rather limited and that the plan is to instruct Varnish to only vary the objects by this header for wikis that do support them, a first good version is to simply trim the header and use only the first language in the list.

Details

SubjectRepoBranchLines +/-
VCL: Normalise the Accept-Language header for the REST APIoperations/puppetproduction+54 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• mobrovac triaged this task as High priority.May 22 2018, 7:41 PM
• mobrovac created this task.
Restricted Application added a project: SRE. · View Herald TranscriptMay 22 2018, 7:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• mobrovac added a parent task: T159985: Implement language variant support in the REST API.May 22 2018, 7:41 PM
gerritbot subscribed.May 22 2018, 7:46 PM

Change 434558 had a related patch set uploaded (by Mobrovac; owner: Mobrovac):
[operations/puppet@production] VCL: Normalise the Accept-Language header for the REST API

https://gerrit.wikimedia.org/r/434558

gerritbot added a project: Patch-For-Review.May 22 2018, 7:46 PM
• ema moved this task from Backlog to Caching on the Traffic board.May 23 2018, 7:40 AM
gerritbot added a comment.Jun 7 2018, 10:47 AM

Change 434558 merged by Ema:
[operations/puppet@production] VCL: Normalise the Accept-Language header for the REST API

https://gerrit.wikimedia.org/r/434558

• mobrovac closed this task as Resolved.Jun 7 2018, 11:28 AM
• mobrovac edited projects, added Services (done); removed Patch-For-Review, Services (doing).

Thank you @ema !

• Vvjjkkii renamed this task from Normalise the Accept-Language header for REST API requests to khcaaaaaaa.Jul 1 2018, 1:08 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed • mobrovac as the assignee of this task.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
• mobrovac renamed this task from khcaaaaaaa to Normalise the Accept-Language header for REST API requests.Jul 1 2018, 10:12 AM
• mobrovac closed this task as Resolved.
• mobrovac claimed this task.
• mobrovac removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
• mobrovac updated the task description. (Show Details)
Vgutierrez mentioned this in T269492: Selecting user language in the REST API.Sep 9 2022, 3:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL