Page MenuHomePhabricator

Align configuration variables between tilerator and kartotherian
Closed, ResolvedPublic

Description

We changed the tilerator config variables for style and source to style_location and source_location. We need to do the same with kartotherian, then remove the puppet style variable.

Event Timeline

Vvjjkkii renamed this task from Align configuration variables between tilerator and kartotherian to jhcaaaaaaa.Jul 1 2018, 1:08 AM
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from jhcaaaaaaa to Align configuration variables between tilerator and kartotherian.Jul 2 2018, 3:57 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added a subscriber: Aklapper.

claiming to check if this is still valid

This task description is missing some background info, and unfortunately I can't remember it clearly either. But here's some relevant info about the current state of the deploy and Puppet repos:

The source and style variables in tilerator/deploy were replaced with source_location and style_location in 18faaa6 (dated May 16). Both source and style were previously defined in scap/vars.yaml, and source_location and style_location continue to be.

The style_location variable was added to kartotherian/deploy in c9689f2 (dated May 24, a day after this ticket was filed). There was no style variable previously defined in kartotherian/deploy. A style variable is instead defined in the kartotherian module in Puppet. I believe removing this now-unused variable is the only work remaining to be done for this task.

Change 462340 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[operations/puppet@production] Remove unused 'style' var from Kartotherian module

https://gerrit.wikimedia.org/r/462340

Change 462340 merged by Gehel:
[operations/puppet@production] Remove unused 'style' var from Kartotherian / Tilerator modules

https://gerrit.wikimedia.org/r/462340