Page MenuHomePhabricator

Use hyphenation for Long Lexeme Lemmas
Closed, ResolvedPublic1 Story Points

Description

Problem:
On Lexeme pages with a long Lemma the text of the Lemma is cut off and hides the edit button.

Example:

Screenshot:
Current state with issue shown:

Current state of when it works well (when space is included in Lemma to break it up):

BDD
GIVEN I am on a Lexeme with a long Lemma
WHEN the Lemma is too long to fit the available width
THEN the Lemma is hyphenated according to the rules suitable for its language

Acceptance criteria:

  • Long Lemmas overflow to the next line in the widget
  • Long Lemmas do not hide the edit button

Info:

  • subject was researched in T199078. Recommendation is to use the .hyphens mixin provided by MW on .wb-lexemepage .lemma-widget_lemma-value. In order for this to work these nodes need to be marked-up with the correct lemma language(, and directionality)
  • similar form representation question is addressed in T203240

Details

Related Gerrit Patches:
mediawiki/extensions/WikibaseLexeme : masterUse hyphenation for long Lexeme Lemmas

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 23 2018, 11:44 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lydia_Pintscher triaged this task as Medium priority.May 23 2018, 1:36 PM
Lydia_Pintscher renamed this task from Long lexeme lemmas are cut off to [UI glitch] Long Lexeme Lemmas are cut off.May 27 2018, 3:19 PM
Vvjjkkii renamed this task from [UI glitch] Long Lexeme Lemmas are cut off to ggcaaaaaaa.Jul 1 2018, 1:08 AM
Vvjjkkii raised the priority of this task from Medium to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from ggcaaaaaaa to [UI glitch] Long Lexeme Lemmas are cut off.Jul 2 2018, 4:40 AM
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added a subscriber: Aklapper.
Pablo-WMDE renamed this task from [UI glitch] Long Lexeme Lemmas are cut off to Use hyphenation for Long Lexeme Lemmas.Aug 31 2018, 11:46 AM
Pablo-WMDE updated the task description. (Show Details)
Pablo-WMDE updated the task description. (Show Details)Aug 31 2018, 12:24 PM

Change 457426 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Use hyphenation for long Lexeme Lemmas

https://gerrit.wikimedia.org/r/457426

  • I refrained from touching the subject of directionality as I found the challenges described in T203384 and it is not strictly necessary to cover the hyphenation.
  • as this changes templates deployment will require a purge of page caches
Pablo-WMDE removed Pablo-WMDE as the assignee of this task.Sep 3 2018, 1:51 PM
Pablo-WMDE added a subscriber: Pablo-WMDE.

Change 457426 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use hyphenation for long Lexeme Lemmas

https://gerrit.wikimedia.org/r/457426