Description

During the 1 hour test, we got at least 6 messages in the queue with recurring=1 but without a token, resulting in failmails like this:

2018-05-11T09:35:02-07:00 [INFO] Entering logging context 'queue2civicrm'.
2018-05-11T09:35:08-07:00 [ERROR] Error processing message, moving to damaged store.
WmfException@sites/all/modules/wmf_civicrm/wmf_civicrm.module:227 (INVALID_MESSAGE Recurring donation, but no subscription ID or recurring payment token found.
Source: array (
))
2018-05-11T09:36:39-07:00 [DEBUG] Queue is empty.

Details

Subject	Repo	Branch	Lines +/-
Job to add tokens to Ingenico payments	wikimedia/fundraising/SmashPig	master	+207 -0
JobQueueConsumer can hydrate non-JsonSerializableObjects	wikimedia/fundraising/SmashPig	master	+31 -18
Tokenize recurring payments stuck in damaged table	wikimedia/fundraising/crm	master	+56 -14

Customize query in gerrit

Related Objects

Duplicates Merged Here: T194519: Ingenico Recurring: "Recurring donation but no subscription ID or recurring payment token found" error being thrown during import

Event Timeline

Ejegg created this task.May 24 2018, 2:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 24 2018, 2:13 PM

Ejegg triaged this task as Medium priority.May 24 2018, 2:14 PM

Ejegg added projects: Fundraising-Backlog, Fr-Ingenico-integration_2017-18.

Ejegg updated the task description. (Show Details)

• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.May 29 2018, 8:00 PM

jgleeson claimed this task.May 31 2018, 5:22 PM

jgleeson added a project: Fundraising Sprint Karma chameleons hide amongst us.

jgleeson moved this task from Backlog to Doing on the Fundraising Sprint Karma chameleons hide amongst us board.Jun 4 2018, 6:14 PM

jgleeson merged a task: T194519: Ingenico Recurring: "Recurring donation but no subscription ID or recurring payment token found" error being thrown during import.Jun 4 2018, 6:22 PM

jgleeson subscribed.

• DStrine moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Jun 4 2018, 6:36 PM

• DStrine added a project: Fundraising Sprint Lactose is unusually tolerant.Jun 5 2018, 8:34 PM

jgleeson moved this task from Backlog to Doing on the Fundraising Sprint Lactose is unusually tolerant board.Jun 6 2018, 10:26 AM

We're also getting these from the audits. Not sure what the solution is there. Maybe we could go so far as to make the 'tokenizePayment' call from the Civi importer when it sees one of these?

• DStrine added a project: Fundraising Sprint Matt Damon to head up Space Force.Jun 18 2018, 8:21 PM

Change 441317 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] WIP tokenize recurring payments stuck in damaged queue

https://gerrit.wikimedia.org/r/441317

gerritbot added a project: Patch-For-Review.Jun 20 2018, 10:49 PM

Change 441317 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Tokenize recurring payments stuck in damaged table

https://gerrit.wikimedia.org/r/441317

jgleeson moved this task from Backlog to Doing on the Fundraising Sprint Matt Damon to head up Space Force board.Jun 22 2018, 2:18 PM

• Vvjjkkii renamed this task from Ingenico recurring messages missing token to 3ccaaaaaaa.Jul 1 2018, 1:08 AM

• Vvjjkkii removed jgleeson as the assignee of this task.

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

CommunityTechBot renamed this task from 3ccaaaaaaa to Ingenico recurring messages missing token.Jul 2 2018, 4:28 AM

CommunityTechBot assigned this task to jgleeson.

CommunityTechBot lowered the priority of this task from High to Medium.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added subscribers: gerritbot, Aklapper.

Ejegg moved this task from Doing to Review on the Fundraising Sprint Matt Damon to head up Space Force board.Jul 6 2018, 12:26 AM

Ejegg moved this task from Backlog to 1-hour test on the Fr-Ingenico-integration_2017-18 board.Jul 10 2018, 12:29 AM

• DStrine added a project: Fundraising Sprint Naming Sprints Is Not Important.Jul 11 2018, 9:26 PM

Ejegg moved this task from Backlog to Review on the Fundraising Sprint Naming Sprints Is Not Important board.Jul 17 2018, 7:51 PM

Change 441250 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] JobQueueConsumer can hydrate non-JsonSerializableObjects

https://gerrit.wikimedia.org/r/441250

Change 441251 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Job to add tokens to Ingenico payments

https://gerrit.wikimedia.org/r/441251

Ejegg moved this task from Review to Done on the Fundraising Sprint Naming Sprints Is Not Important board.Jul 17 2018, 7:55 PM

Change 441250 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] JobQueueConsumer can hydrate non-JsonSerializableObjects

https://gerrit.wikimedia.org/r/441250

Change 441251 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Job to add tokens to Ingenico payments

https://gerrit.wikimedia.org/r/441251

Ejegg closed this task as Resolved.Jul 23 2018, 5:09 PM