| • Whatamidoing-WMF | |
| May 24 2018, 5:53 PM |
| F18513824: image.png | |
| May 24 2018, 9:04 PM |
Steps to reproduce:
Result:
Nothing happens.
Expected result:
The copied section gets pasted into the blank space.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Release | • mmodell | T191051 1.32.0-wmf.5 deployment blockers | ||
| Resolved | Esanders | T195514 Can't copy and paste a list on office.wiki page in the visual editor |
Minimal test case:
A * B ** C * D
Selecting text from B to D (indexes 6-19):
Uncaught Error: Inserted data is trying to close the root node (at index 9)
at writeElement (/w/extensions/VisualEditor/lib/ve/src/dm/ve.dm.Document.js?11616:1280)
at VeDmDocument.ve.dm.Document.fixupInsertion (/w/extensions/VisualEditor/lib/ve/src/dm/ve.dm.Document.js?11616:1482)
at VeDmTransactionBuilder.ve.dm.TransactionBuilder.pushInsertion (/w/extensions/VisualEditor/lib/ve/src/dm/ve.dm.TransactionBuilder.js?ccb8f:884)
at Object.ve.dm.TransactionBuilder.static.newFromInsertion (/w/extensions/VisualEditor/lib/ve/src/dm/ve.dm.TransactionBuilder.js?ccb8f:56)
at VeDmSurfaceFragment.ve.dm.SurfaceFragment.insertContent (/w/extensions/VisualEditor/lib/ve/src/dm/ve.dm.SurfaceFragment.js?7dada:849)
at VeCeSurface.ve.ce.Surface.afterPasteInsertInternalData (/w/extensions/VisualEditor/lib/ve/src/ce/ve.ce.Surface.js?94ab2:2195)
at VeCeSurface.ve.ce.Surface.afterPasteAddToFragmentFromInternal (/w/extensions/VisualEditor/lib/ve/src/ce/ve.ce.Surface.js?94ab2:2185)
at VeCeSurface.ve.ce.Surface.afterPaste (/w/extensions/VisualEditor/lib/ve/src/ce/ve.ce.Surface.js?94ab2:2008)
at /w/extensions/VisualEditor/lib/ve/src/ce/ve.ce.Surface.js?94ab2:1836Actually you don't even need nested lists:
* [A * B]
fixupInsertion is not happy about the unbalanced range being pasted (specifically the close listItems)
In the past we ran this in a try/catch block, and fell back to a different method if it couldn't be fixed up.
Looks like in the refactor of afterPasteExtractClipboardData we moved the #insertContent call (the one that throws the exception) out of the try/catch block. We should also have had some tests for this...
Change 435155 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Fix try/catch in internal paste with original data
Change 435155 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Fix try/catch in internal paste with original data
Change 435203 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a17837fa6)
Change 435203 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a17837fa6)
Change 435292 had a related patch set uploaded (by Jforrester; owner: Esanders):
[VisualEditor/VisualEditor@wmf/1.32.0-wmf.5] Fix try/catch in internal paste with original data
Has this fix been deployed? I'd like to get wmf.5 pushed out today if it's possible to get the train back on track.
Mentioned in SAL (#wikimedia-operations) [2018-05-28T19:07:44Z] <twentyafterfour> attempting to get the wmf.5 train back on track. Deploying a fix for T195514 (https://gerrit.wikimedia.org/r/c/435292/) to unblock T191051
Change 435292 merged by 20after4:
[VisualEditor/VisualEditor@wmf/1.32.0-wmf.5] Fix try/catch in internal paste with original data
Change 435825 had a related patch set uploaded (by 20after4; owner: 20after4):
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.5] lib/ve submodule bump (gerrit didn't do it automatically...)
Mentioned in SAL (#wikimedia-operations) [2018-05-28T20:14:30Z] <twentyafterfour> Test failures on https://gerrit.wikimedia.org/r/#/c/435825/ are preventing deployment of the fix for a critical deployment blocker (see T195514) 1.32.0-wmf.5 still blocked refs T191051
Change 436049 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.5] Update VE core submodule to wmf/1.32.0-wmf.5 HEAD (9032a90ca)
Change 435825 abandoned by Jforrester:
lib/ve submodule bump (gerrit didn't do it automatically...)
Mentioned in SAL (#wikimedia-operations) [2018-05-29T19:16:40Z] <thcipriani> cutting branch for wmf.6, will not deploy wmf.6 as wmf.5 is not currently on group2 as the train is blocked on T195514 which is blocked on T195868 which is blocked on T195906
Change 436049 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.5] Update VE core submodule to wmf/1.32.0-wmf.5 HEAD (9032a90ca)
Mentioned in SAL (#wikimedia-operations) [2018-05-29T21:06:07Z] <thcipriani@tin> Synchronized php-1.32.0-wmf.5/extensions/VisualEditor/lib/ve: SWAT: [[gerrit:436049|Update VE core submodule to wmf/1.32.0-wmf.5 HEAD (9032a90ca)]] T195514 (duration: 01m 23s)