See https://bugs.python.org/issue22493
I propose to deprecate (and then forbid in 3.7) the use of inline flags not at the start of regular expression. This will help to change the meaning of inline flags in the middle of the expression in future (in 3.8 or later).
DeprecationWarning: Flags not at the start of the expression
happens in textlib.removeDisabledParts()
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| textlib._create_default_regexes: Avoid using inline flags | Dalba | pywikibot/core | master | +54 -43 | |
| [fix] Remove inline flags in removeDisabledParts | Xqt | pywikibot/core | master | +15 -2 |
We can change framework regexes und should do that imho. But how can we deprecate this usage inside a foreign script when using pywikibot?
Probably this will be handled by Python itself? The deprecation warning from removeExcept is thrown by Python or not?
DeprecationWarning is issued by python.
We should change the framework regexes so that we do not get it due to our own code.
Script owners are on their own, I think. They are getting the same warning, they should fix their code.
happens in textlib.removeDisabledParts()
That happens by joining multiple regexes where most of them has inline flags in front.
Change 435686 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [fix] Remove inline flags in removeDisabledParts
Change 435686 abandoned by Xqt:
[fix] Remove inline flags in removeDisabledParts
Reason:
Hopefully there will be a possibility to merge patterns and resolve
> their issues in the future: http://bugs.python.org/issue33658
Stalled until an upstream solution is published, see http://bugs.python.org/issue33658
There was proposed a workaround introduced in py3.7: https://bugs.python.org/issue33658 So basically we will need two sets of patterns, one set for py3.6- and one for py3.7+. But this is really not ideal :/
Change 445851 had a related patch set uploaded (by Dalba; owner: dalba):
[pywikibot/core@master] textlib._create_default_regexes: Avoid using inline flags
Change 445851 merged by jenkins-bot:
[pywikibot/core@master] textlib._create_default_regexes: Avoid using inline flags