Maniphest T195580

Can't edit preferences on Beta Cluster due to PHP fatal error
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Daimona
	May 25 2018, 12:35 PM

Description

I just created another account on Beta Cluster to test an AF bug. In order to be comfortable with editing interface, I went to preferences to disable the new editor. However, when I attempt to save, I get the following error:

Sounds like something with preferences is broken, and in fact it happens for every preference option. Although this only happens on Beta Cluster (group 0 is clean), I still have to determine whether it's a problem with BC itself or something that'll go in the next train.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix for changes to preferences form	mediawiki/extensions/Popups	master	+3 -3

Customize query in gerrit

Related Objects

Mentioned In: T22647: Allow way to choose thumbnail frame for video on its File: description page
T195605: Can't enable Popups in Special:Preferences (PreferencesFormLegacy passed, PreferencesForm expected)
Mentioned Here: rMWc513ec19efa7: Restore 'PreferencesForm' as alias for 'PreferencesFormLegacy'

Event Timeline

Daimona created this task.May 25 2018, 12:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 25 2018, 12:35 PM

Daimona added projects: Page-Previews, MediaWiki-Core-Preferences.May 25 2018, 12:53 PM

This is probably related to rMWc513ec19efa7: Restore 'PreferencesForm' as alias for 'PreferencesFormLegacy', which attempted to resolve this with a class alias by having PreferencesForm extend PreferencesFormLegacy. (https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/specials/forms/PreferencesFormLegacy.php$152)

• brooke mentioned this in T195605: Can't enable Popups in Special:Preferences (PreferencesFormLegacy passed, PreferencesForm expected).May 25 2018, 4:34 PM

• brooke mentioned this in T22647: Allow way to choose thumbnail frame for video on its File: description page.

• brooke merged a task: T195605: Can't enable Popups in Special:Preferences (PreferencesFormLegacy passed, PreferencesForm expected).May 25 2018, 4:48 PM

• brooke subscribed.

Change 435194 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/Popups@master] Fix for changes to preferences form

https://gerrit.wikimedia.org/r/435194

gerritbot added a project: Patch-For-Review.May 25 2018, 4:52 PM

Change 435194 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Fix for changes to preferences form

https://gerrit.wikimedia.org/r/435194