Maniphest T195605

Can't enable Popups in Special:Preferences (PreferencesFormLegacy passed, PreferencesForm expected)
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	brion
	May 25 2018, 4:33 PM

Description

Tried to enable "page previews" in Special:Preferences on my local test wiki, just freshly updated. On save, got this exception:

[63433c23a78794244a339fe8] /wiki/Special:Preferences TypeError from line 80 of /vagrant/mediawiki/extensions/Popups/includes/UserPreferencesChangeHandler.php: Argument 2 passed to Popups\UserPreferencesChangeHandler::onPreferencesFormPreSave() must be an instance of PreferencesForm, instance of PreferencesFormLegacy given, called in /vagrant/mediawiki/includes/Hooks.php on line 177

Backtrace:

#0 /vagrant/mediawiki/includes/Hooks.php(177): Popups\UserPreferencesChangeHandler::onPreferencesFormPreSave(array, PreferencesFormLegacy, User, boolean, array)
#1 /vagrant/mediawiki/includes/Hooks.php(205): Hooks::callHook(string, array, array, NULL)
#2 /vagrant/mediawiki/includes/preferences/DefaultPreferencesFactory.php(1693): Hooks::run(string, array)
#3 /vagrant/mediawiki/includes/preferences/DefaultPreferencesFactory.php(1724): MediaWiki\Preferences\DefaultPreferencesFactory->saveFormData(array, PreferencesFormLegacy)
#4 /vagrant/mediawiki/includes/preferences/DefaultPreferencesFactory.php(1525): MediaWiki\Preferences\DefaultPreferencesFactory->submitForm(array, PreferencesFormLegacy)
#5 /vagrant/mediawiki/includes/htmlform/HTMLForm.php(664): MediaWiki\Preferences\DefaultPreferencesFactory->MediaWiki\Preferences\{closure}(array, PreferencesFormLegacy)
#6 /vagrant/mediawiki/includes/htmlform/HTMLForm.php(556): HTMLForm->trySubmit()
#7 /vagrant/mediawiki/includes/htmlform/HTMLForm.php(571): HTMLForm->tryAuthorizedSubmit()
#8 /vagrant/mediawiki/includes/specials/SpecialPreferences.php(159): HTMLForm->show()
#9 /vagrant/mediawiki/includes/specialpage/SpecialPage.php(522): SpecialPreferences->execute(NULL)
#10 /vagrant/mediawiki/includes/specialpage/SpecialPageFactory.php(569): SpecialPage->run(NULL)
#11 /vagrant/mediawiki/includes/MediaWiki.php(288): SpecialPageFactory::executePath(Title, RequestContext)
#12 /vagrant/mediawiki/includes/MediaWiki.php(863): MediaWiki->performRequest()
#13 /vagrant/mediawiki/includes/MediaWiki.php(524): MediaWiki->main()
#14 /vagrant/mediawiki/index.php(42): MediaWiki->run()
#15 /var/www/w/index.php(5): require(string)
#16 {main}

Related Objects

Mentioned Here: T195580: Can't edit preferences on Beta Cluster due to PHP fatal error

Event Timeline

brion created this task.May 25 2018, 4:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 25 2018, 4:33 PM

Probably same as T195580?

brion closed this task as a duplicate of T195580: Can't edit preferences on Beta Cluster due to PHP fatal error.May 25 2018, 4:48 PM

• Vvjjkkii renamed this task from Can't enable Popups in Special:Preferences (PreferencesFormLegacy passed, PreferencesForm expected) to u9baaaaaaa.Jul 1 2018, 1:08 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from u9baaaaaaa to Can't enable Popups in Special:Preferences (PreferencesFormLegacy passed, PreferencesForm expected).Jul 2 2018, 3:44 PM

CommunityTechBot closed this task as a duplicate.

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

Can't enable Popups in Special:Preferences (PreferencesFormLegacy passed, PreferencesForm expected)Closed, DuplicatePublicActions

Description

Related Objects

Event Timeline

Can't enable Popups in Special:Preferences (PreferencesFormLegacy passed, PreferencesForm expected)
Closed, DuplicatePublic
Actions